open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: disable redundant exclude-by-url checkbox

Browse Source
This commit is contained in:
eight 2019-02-13 10:07:40 +08:00
parent 9101ee9219
commit f7d0853f84
3 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
_locales/en/messages.json
View File

@ -321,6 +321,9 @@
"excludeStyleByUrlLabel": {
"message": "Exclude the current URL"
},
"excludeStyleByUrlRedundant": {
"message": "The current URL is the domain page"
},
"exportLabel": {
"message": "Export",
"description": "Label for the button to export a style ('edit' page) or all styles ('manage' page)"

4
popup/popup.css
View File

@ -367,6 +367,10 @@ a.configure[target="_blank"] .svg-icon.config {
display: block;
margin: 0 auto;
}
.entry .menu-item.disabled {
opacity: 0.5;
background-color: transparent;
}
/* checkbox */
.checkbox-container {

11
popup/popup.js
View File

@ -335,7 +335,16 @@ function createStyleElement(style) {
entry.classList.toggle('regexp-partial', style.sloppy);
$('.exclude-by-domain-checkbox', entry).checked = styleExcluded(style, 'domain');
$('.exclude-by-url-checkbox', entry).checked = styleExcluded(style, 'url');
const excludeByUrlCheckbox = $('.exclude-by-url-checkbox', entry);
const isRedundant = getExcludeRule('domain') === getExcludeRule('url');
excludeByUrlCheckbox.checked = !isRedundant && styleExcluded(style, 'url');
excludeByUrlCheckbox.disabled = isRedundant;
const excludeByUrlLabel = $('.exclude-by-url', entry);
excludeByUrlLabel.classList.toggle('disabled', isRedundant);
excludeByUrlLabel.title = isRedundant ?
chrome.i18n.getMessage('excludeStyleByUrlRedundant') : '';
return entry;
}