quantified.uncertainty/squiggle
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tweak: Use firstErrorOrOpen instead of hack

Browse Source
This commit is contained in:
NunoSempere 2022-09-06 14:54:59 +02:00
parent fc2d647b62
commit 162f158dbc
1 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
packages/squiggle-lang/src/rescript/FunctionRegistry/Library/FR_Danger.res
View File

@ -96,7 +96,6 @@ module Integration = {
) )
// Gotcha: makeBy goes from 0 to (n-1): <https://rescript-lang.org/docs/manual/latest/api/belt/array#makeby> // Gotcha: makeBy goes from 0 to (n-1): <https://rescript-lang.org/docs/manual/latest/api/belt/array#makeby>
let ysOptions = Belt.Array.map(innerXs, x => applyFunctionAtFloatToFloatOption(x)) let ysOptions = Belt.Array.map(innerXs, x => applyFunctionAtFloatToFloatOption(x))
let okYs = E.A.R.filterOk(ysOptions)
/* Logging, with a worked example. */ /* Logging, with a worked example. */
// Useful for understanding what is happening. // Useful for understanding what is happening.
@ -122,12 +121,12 @@ module Integration = {
Js.Console.log2("innerPointIncrement", innerPointIncrement) // (10-0)/4 = 2.5 Js.Console.log2("innerPointIncrement", innerPointIncrement) // (10-0)/4 = 2.5
Js.Console.log2("innerXs", innerXs) // 2.5, 5, 7.5 Js.Console.log2("innerXs", innerXs) // 2.5, 5, 7.5
Js.Console.log2("ysOptions", ysOptions) Js.Console.log2("ysOptions", ysOptions)
Js.Console.log2("okYs", okYs)
} }
//This is pretty hacky. It should use a result type instead of checking that length matches. //This is pretty hacky. It should use a result type instead of checking that length matches.
let result = if E.A.length(ysOptions) == E.A.length(okYs) { let result = switch E.A.R.firstErrorOrOpen(ysOptions) {
let innerPointsSum = okYs->E.A.reduce(0.0, (a, b) => a +. b) | Ok(ys) => {
let innerPointsSum = ys->E.A.reduce(0.0, (a, b) => a +. b)
let resultWithOuterPoints = switch ( let resultWithOuterPoints = switch (
applyFunctionAtFloatToFloatOption(min), applyFunctionAtFloatToFloatOption(min),
applyFunctionAtFloatToFloatOption(max), applyFunctionAtFloatToFloatOption(max),
@ -142,9 +141,12 @@ module Integration = {
| (_, Error(b)) => Error(b) | (_, Error(b)) => Error(b)
} }
resultWithOuterPoints resultWithOuterPoints
} else { }
| Error(b) =>
Error( Error(
"Integration error 3 in Danger.integrate. It's possible that your function doesn't return a number, try definining auxiliaryFunction(x) = mean(yourFunction(x)) and integrate auxiliaryFunction instead", "Integration error 3 in Danger.integrate. It's possible that your function doesn't return a number, try definining auxiliaryFunction(x) = mean(yourFunction(x)) and integrate auxiliaryFunction instead." ++
"Original error: " ++
b,
) )
} }
result result