2fd531e253
* Add: implement new linter system * Refactor: pull out editor worker * Switch to new linter and worker * Enable eslint cache * Fix: undefined error * Windows compatibility * Fix: refresh linter if the editor.linter changes * Add: stylelint * Add: getStylelintRules, getCsslintRules * Fix: logic to get correct linter * WIP: linter-report * Fix: toggle hidden state * Add: matain the order of lint report for section editor * Add: unhook event * Add: gotoLintIssue * Fix: shouldn't delete rule.init * Add: linter-help-dialog * Drop linterConfig * Add: linter-config-dialog, cacheFn * Add: use cacheFn * Drop lint.js * Add: refresh. Fix report order * Fix: hide empty table * Add: updateCount. Fix table caption * Switch to new linter/worker * Fix: remove unneeded comment * Fix: cacheFn -> cacheFirstCall * Fix: use cacheFirstCall * Fix: cache metaIndex * Fix: i < trs.length * Fix: drop isEmpty * Fix: expose some simple states to global * Fix: return object code style * Fix: use proxy to reflect API * Fix: eslint-disable-line -> eslint-disable-next-line * Fix: requestId -> id * Fix: one-liner * Fix: one-liner * Fix: move dom event block to top * Fix: pending -> pendingResponse * Fix: onSuccess -> onUpdated * Fix: optimize row removing when i === 0 * Fix: hook/unhook -> enableForEditor/disableForEditor * Fix: linter.refresh -> linter.run * Fix: some shadowing * Fix: simplify getAnnotations * Fix: cacheFirstCall -> memoize * Fix: table.update -> table.updateCaption * Fix: unneeded reassign * Fix: callbacks -> listeners * Fix: don't compose but extend * Refactor: replace linter modules with linter-defaults and linter-engines * Fix: implement linter fallbacks * Fix: linter.onChange -> linter.onLintingUpdated * Fix: cms -> tables * Fix: parseMozFormat is not called correctly * Move csslint-loader to background * Fix: watch config changes * Fix: switch to LINTER_DEFAULTS * Fix: csslint-loader -> parserlib-loader
166 lines
4.3 KiB
JavaScript
166 lines
4.3 KiB
JavaScript
/* global linter editors clipString createLinterHelpDialog makeSectionVisible */
|
|
'use strict';
|
|
|
|
// eslint-disable-next-line no-var
|
|
Object.assign(linter, (() => {
|
|
const tables = new Map();
|
|
const helpDialog = createLinterHelpDialog(getIssues);
|
|
|
|
document.addEventListener('DOMContentLoaded', () => {
|
|
$('#lint-help').addEventListener('click', helpDialog.show);
|
|
}, {once: true});
|
|
|
|
linter.onLintingUpdated((annotationsNotSorted, annotations, cm) => {
|
|
let table = tables.get(cm);
|
|
if (!table) {
|
|
table = createTable(cm);
|
|
tables.set(cm, table);
|
|
const container = $('.lint-report-container');
|
|
if (typeof editor === 'object') {
|
|
container.append(table.element);
|
|
} else {
|
|
const nextSibling = findNextSibling(tables, cm);
|
|
container.insertBefore(table.element, nextSibling && tables.get(nextSibling).element);
|
|
}
|
|
}
|
|
table.updateCaption();
|
|
table.updateAnnotations(annotations);
|
|
updateCount();
|
|
});
|
|
|
|
linter.onUnhook(cm => {
|
|
const table = tables.get(cm);
|
|
if (table) {
|
|
table.element.remove();
|
|
tables.delete(cm);
|
|
}
|
|
updateCount();
|
|
});
|
|
|
|
return {refreshReport};
|
|
|
|
function updateCount() {
|
|
const issueCount = Array.from(tables.values())
|
|
.reduce((sum, table) => sum + table.trs.length, 0);
|
|
$('#lint').classList.toggle('hidden', issueCount === 0);
|
|
$('#issue-count').textContent = issueCount;
|
|
}
|
|
|
|
function getIssues() {
|
|
const issues = new Set();
|
|
for (const table of tables.values()) {
|
|
for (const tr of table.trs) {
|
|
issues.add(tr.getAnnotation());
|
|
}
|
|
}
|
|
return issues;
|
|
}
|
|
|
|
function findNextSibling(tables, cm) {
|
|
let i = editors.indexOf(cm) + 1;
|
|
while (i < editors.length) {
|
|
if (tables.has(editors[i])) {
|
|
return editors[i];
|
|
}
|
|
i++;
|
|
}
|
|
}
|
|
|
|
function refreshReport() {
|
|
for (const table of tables.values()) {
|
|
table.updateCaption();
|
|
}
|
|
}
|
|
|
|
function createTable(cm) {
|
|
const caption = $create('caption');
|
|
const tbody = $create('tbody');
|
|
const table = $create('table', [caption, tbody]);
|
|
const trs = [];
|
|
return {
|
|
element: table,
|
|
trs,
|
|
updateAnnotations,
|
|
updateCaption
|
|
};
|
|
|
|
function updateCaption() {
|
|
caption.textContent = typeof editor === 'object' ?
|
|
'' : `${t('sectionCode')} ${editors.indexOf(cm) + 1}`;
|
|
}
|
|
|
|
function updateAnnotations(lines) {
|
|
let i = 0;
|
|
for (const anno of getAnnotations()) {
|
|
let tr;
|
|
if (i < trs.length) {
|
|
tr = trs[i];
|
|
} else {
|
|
tr = createTr();
|
|
trs.push(tr);
|
|
tbody.append(tr.element);
|
|
}
|
|
tr.update(anno);
|
|
i++;
|
|
}
|
|
if (i === 0) {
|
|
trs.length = 0;
|
|
tbody.textContent = '';
|
|
} else {
|
|
while (trs.length > i) {
|
|
trs.pop().element.remove();
|
|
}
|
|
}
|
|
table.classList.toggle('empty', trs.length === 0);
|
|
|
|
function *getAnnotations() {
|
|
for (const line of lines.filter(Boolean)) {
|
|
yield *line;
|
|
}
|
|
}
|
|
}
|
|
|
|
function createTr() {
|
|
let anno;
|
|
const severityIcon = $create('div');
|
|
const severity = $create('td', {attributes: {role: 'severity'}}, severityIcon);
|
|
const line = $create('td', {attributes: {role: 'line'}});
|
|
const col = $create('td', {attributes: {role: 'col'}});
|
|
const message = $create('td', {attributes: {role: 'message'}});
|
|
|
|
const trElement = $create('tr', {
|
|
onclick: () => gotoLintIssue(cm, anno)
|
|
}, [
|
|
severity,
|
|
line,
|
|
$create('td', {attributes: {role: 'sep'}}, ':'),
|
|
col,
|
|
message
|
|
]);
|
|
return {
|
|
element: trElement,
|
|
update,
|
|
getAnnotation: () => anno
|
|
};
|
|
|
|
function update(_anno) {
|
|
anno = _anno;
|
|
trElement.className = anno.severity;
|
|
severity.dataset.rule = anno.rule;
|
|
severityIcon.className = `CodeMirror-lint-marker-${anno.severity}`;
|
|
severityIcon.textContent = anno.severity;
|
|
line.textContent = anno.from.line + 1;
|
|
col.textContent = anno.from.ch + 1;
|
|
message.title = clipString(anno.message, 1000) + `\n(${anno.rule})`;
|
|
message.textContent = clipString(anno.message, 100);
|
|
}
|
|
}
|
|
}
|
|
|
|
function gotoLintIssue(cm, anno) {
|
|
makeSectionVisible(cm);
|
|
cm.focus();
|
|
cm.setSelection(anno.from);
|
|
}
|
|
})());
|