tophf
5529cbec2b
fix and simplify editDeleteText context menu
...
* enable it on inputs added by the user later
* enable it in all of our pages
2022-01-28 03:11:25 +03:00
tophf
e54178a43c
draft recovery in editor ( #1388 )
...
+ use toolbox::clamp() more
2022-01-23 12:44:25 +03:00
tophf
cc7eba979e
save-as-template button in editor ( #1385 )
...
+ keep i18n attributes to use them as CSS selectors
+ reduce flicker when creating a new style
+ split button
2022-01-19 14:45:45 +03:00
tophf
68dc584749
deduplicate editor.useSavedStyle
...
...and call it when saving in sectioned editor (regressed in ba9d904c
2022-01-10 21:31:15 +03:00
tophf
6e4fc3236e
confirm reload in sectioned editor
2022-01-10 19:12:29 +03:00
tophf
906508832b
show style settings in a dialog ( #1374 )
...
+ simplify css/html
+ save button and autosave checkbox just like in config-dialog
+ generalize can-close-on-esc
+ add `props` parameter to helpPopup.show
+ deduplicate usage of #help-popup id
+ uniform padding in popups
+ disambiguate style settings from editor options
2021-12-29 22:57:22 +03:00
tophf
8128100cef
ensure editor window is visible
...
fixes #1375
2021-12-26 19:35:13 +03:00
eight
9d1243073b
Add: style settings ( #1358 )
...
* Add: style settings
* Change: use radio instead of select for dark/light mode
* Change: x -> Delete
* Change: (in|ex)clusion messages
* Fix: avoid extra space when there is no rule
* Fix: UI in mobile
* Change: delete priority
* Change: use textarea for include/exclude, remove isCodeUpdated
* Fix: separate toggle
* Fix: minor
* Fix: remove codeIsUpdated in styleman
2021-12-07 12:44:49 +08:00
tophf
6798114196
add buttons to hotkey input, reset on Del/BackSpace
2021-08-06 16:01:55 +03:00
tophf
6650a37194
tidy up USW-related UI and code ( #1285 )
...
* shortened the title to "Publish" and fixed the compact mode
* made collapsed <details> share the same line in compact mode
* made hard-coded strings localizable
* IIFE modules instead of generically named globals
* unified and sorted the names of localized messages
* adjusted spacing of header items
* center auth popup to current window
Co-authored-by: Gusted <williamzijl7@hotmail.com>
2021-07-30 15:44:06 +03:00
tophf
ebb5fcafbc
show sections on compact->normal layout switch
2021-07-30 07:58:08 +03:00
Gusted
69ccdb0591
Show error to user when USw returns error ( #1286 )
...
Related USw commit: d4306f2f71
2021-07-18 07:25:32 +03:00
Gusted
fe45781545
Linking Styles to USW ( #1256 )
...
* Prototype
Just able to log the token for the requested style.
* Store USw Token
* Fix linting
* Add revoke capabilities
* Add upload capabilities + UI?
* Add credentials for production server
* Patch up several things
* Send styleInfo
We will be adding the feature to add style based of the currentStyle, see paring commit 31813da300461ddb03c77d8c4c1248
2021-06-29 05:36:59 -04:00
tophf
eb5fd90dc7
remember CM bookmarks on reload/revisit
2021-01-12 17:39:24 +03:00
tophf
fe176c9b62
[compact layout] show sections TOC on first click
2021-01-09 13:21:06 +03:00
tophf
767b2017e0
wait for main stylesheet to load before forcing layout
2021-01-05 19:54:49 +03:00
tophf
fdbfb23547
API groups + use executeScript for early injection ( #1149 )
...
* parserlib: fast section extraction, tweaks and speedups
* csslint: "simple-not" rule
* csslint: enable and fix "selector-newline" rule
* simplify db: resolve with result
* simplify download()
* remove noCode param as it wastes more time/memory on copying
* styleManager: switch style<->data names to reflect their actual contents
* inline method bodies to avoid indirection and enable better autocomplete/hint/jump support in IDE
* upgrade getEventKeyName to handle mouse clicks
* don't trust location.href as it hides text fragment
* getAllKeys is implemented since Chrome48, FF44
* allow recoverable css errors + async'ify usercss.js
* openManage: unminimize windows
* remove the obsolete Chrome pre-65 workaround
* fix temporal dead zone in apply.js
* ff bug workaround for simple editor window
* consistent window scrolling in scrollToEditor and jumpToPos
* rework waitForSelector and collapsible <details>
* blank paint frame workaround for new Chrome
* extract stuff from edit.js and load on demand
* simplify regexpTester::isShown
* move MozDocMapper to sections-util.js
* extract fitSelectBox()
* initialize router earlier
* use helpPopup.close()
* fix autofocus in popups, follow-up to 5bb1b5ef
2021-01-01 17:27:58 +03:00
tophf
e6f94378bf
re-enable linter after import + async'ify
...
regressed in 420733b9
2020-11-29 14:25:07 +03:00
tophf
a87c49f0fc
autoresize embedded popup for config dialogs
2020-11-27 15:09:16 +03:00
tophf
6451eb533c
switch to styleMissingName
2020-11-26 12:09:11 +03:00
tophf
355f240779
add a suffix in editor title
2020-11-26 12:04:42 +03:00
tophf
8b58b22825
[simple-window editor] embed popup as iframe
2020-11-24 12:16:23 +03:00
tophf
70e3ba15b7
use 'default' internally for the default theme element
...
* the pref won't be influenced by the current UI language
* also reset to 'default' if failed to load the theme's css file
2020-11-20 16:10:15 +03:00
tophf
420733b93a
PatchCSP + tweaks/fixes/features ( #1107 )
...
* add Patch CSP option
* show style version, size, and update age in manager
* add scope selector to style search in manager
* keep scroll position and selections in tab's session
* directly install usercss from raw github links
* ditch localStorage, use on-demand SessionStore proxy
* simplify localization
* allow <code> tag in i18n-html
* keep nodes in HTML templates
* API.getAllStyles is actually faster with code untouched
* fix fitToContent when applies-to is taller than window
* dedupe linter.enableForEditor calls
* prioritize visible CMs in refreshOnViewListener
* don't scroll to last style on editing a new one
* delay colorview for invisible CMs
* eslint comma-dangle error + autofix files
* styleViaXhr: also toggle for disableAll pref
* styleViaXhr: allow cookies for sandbox CSP
* simplify notes in options
* simplify getStylesViaXhr
* oldUI fixups:
* remove separator before 1st applies-to
* center name bubbles
* fix updateToc focus on a newly added section
* fix fitToContent when cloning section
* remove CSS `contain` as it makes no difference
* replace overrides with declarative CSS + code cosmetics
* simplify adjustWidth and make it work in FF
2020-11-18 14:17:15 +03:00
tophf
0b3e027bfd
auto-promisify browser.* methods on call
2020-11-13 20:07:43 +03:00
tophf
5e5fecbcfe
editor: section labels, TOC, tweaks ( #1086 )
...
* section labels, TOC, speedups and fixes
* show section numbers in widgets
* debounce livePreview in usercss editor
* better fixed header and compact layout compatibility
* fix section sizing for compact layout + layout speedup
* DocFuncMapper + cosmetics + fix Clone button
* don't run linter during initSections
* remove unused/unnecessary DOM polyfills
* report invalid @document function as parser error
* rewrite section finder
* simplify focusedViaClick
* simplify setPreprocessor and make it synchronous
* throttle offscreen line widgets in usercss with lots of sections
* add on, off aliases for add/removeEventListener + onOff
* use on/off aliases in changed files
* use getters in more places
2020-11-08 11:12:42 +03:00
tophf
2747d3930b
simplify resizing of editor-in-new-window
2020-10-26 18:04:37 +03:00
tophf
54605c838b
set customName only on user input
2020-10-22 23:48:17 +03:00
tophf
bc6c9c826a
make editor load even faster
...
* reorder scripts
* make style request earlier
2020-10-22 15:03:07 +03:00
tophf
2e1a903cc7
fix local name customization for usercss/legacy
2020-10-22 15:01:49 +03:00
tophf
9e487b03e5
tweak editor ( #1063 )
...
* also apply live-preview if an unsaved style was disabled
* use box-shadow instead of outline for focus everywhere
* allow focus outline on click in text/search input or textarea
* search inputs should use the same style as text inputs
* also use box-shadow focus on delete buttons
* remove URLSearchParams workaround, not needed since Chrome 55
* use `once` in addEventListener, available since Chrome 55
* update USO bug workarounds, remove obsolete ones
* ping/pong to fix openURL with `message` in FF
* use unprefixed CSS filter, available since Chrome 53
* use unprefixed CSS user-select, available since Chrome 54
* focus tweaks
* also use text query in inline search for Stylus category
* use event.key, available since Chrome 51
Co-authored-by: narcolepticinsomniac
2020-10-13 21:14:54 +03:00
tophf
60fc6f2456
Editor fixes, make sectioned editor open quickly again ( #1061 )
...
* make usercss editor full-height again
* make sectioned editor open quickly again
* remove leftovers
* autofocus when add/clone button is clicked
* don't fit to content on clicking the add button
* scroll the window to show a manually added section entirely
* autofocus on a manually added applies-to
* disable Save button while loading
* use standard CSS for a focused CodeMirror outline
* trigger refresh sooner by one viewport in advance
* declare refreshOnView as a standard function
* run fixedHeader asynchronously to prevent self-triggering
* account for header in compact mode when fitting to content
* code cosmetics
2020-10-11 17:13:25 +03:00
tophf
54b1f218e0
Enhance: promisify chrome into browser, drop promisify ( #866 )
...
* promisify `chrome` into `browser`
* comment
* comment
* comment
* Add: a naive browser polyfill
* Fix: polyfill doesn't detect content script env correctly
Co-authored-by: eight04 <eight04@gmail.com>
2020-08-14 20:16:01 +08:00
tophf
d18314357f
use onBoundsChanged to remember editor size/position ( #1007 )
2020-08-02 00:00:44 -04:00
tophf
60a37af0e0
add a hotkey & right-click to beautify silently ( #972 )
...
* add a hotkey & right-click to beautify silently
* fix closestVisible
2020-06-22 12:14:41 -04:00
narcolepticinsomniac
793dc20722
linter and compact layout improvements ( #749 )
...
* linter and compact layout improvements
Closes #748
While investigating the best way to fix linter scrolling, when I double-checked the compact layout, an old bug I meant to fix a long time ago was immediately apparent. Basically, the linter adds/removes errors as you type, causing the editor to bounce up and down, making it practically unusable.
This PR fixes scrolling, and also collapses options and the linter in the compact layout, but always shows the collapsed linter so you're aware of the error count without the content jumping. It also collapses options in the non-compact layout if the viewport is too short to accommodate them, factoring in the min-height of the linter. All automatic collapsing factors in whether a linter is active so they can adjust accordingly, and disables the setting of collapsed state prefs, since we're deciding the pref anyway, and this allows for re-expanding on resize based on the previous pref.
It's quite possible I failed to account for certain scenarios, so try to break it. Also think it's problematic for the linter to not always be visible if enabled, so I hooked up a 40px fixed header on scroll with just the linter in it for the compact layout.
A few other little details are included. I removed redundant line and column numbers spelled out at the end of lint messages to prevent horizontal overflow. I noticed that the expand/collapse prefs do not toggle correctly when clicking directly on the details-marker arrow. Simplest solution was covering them with the `h2` (we may wanna hook up the manager as well). Also, unrelated, but I switched to opacity to hide resizing sectioned editors, because `visibility: hidden;` breaks editor auto-focus.
If either of you guys wanna fix any bugs, or improve any code, feel free to just commit to this PR directly.
* linter and compact layout improvements
* linter and compact layout improvements
* No usercss scroll listener and delay header check
* Some code tweaks
2019-08-04 13:09:50 -04:00
Rob Garrison
a1b17bb553
Fix dirty style updating. Closes #585 ( #586 )
...
* Fix dirty style updating. Closes #585
* Move common code to edit.js
* init updateDirty
2018-11-27 22:54:36 -06:00
eight
4db8a9ea9a
Fix: output codemirror themes to a separated file ( #538 )
2018-11-07 05:33:14 -06:00
eight
e3d3604afc
Refactor the entire storage system and the section editor ( #518 )
...
* Squashed commit of the following:
commit d84c4dc3fe46027120ecf85d4de39b81f3e69574f9dc04558ffea04d591f2aff14e213d4ddfcc71385e70491e47acb131642a39405ac4c14c2fdbb58fb1b49b8bb2c2d849fa4f133c3e67a05a6208f5c05a87ed00f576f73f333e93819deb439b11685b49dd3cd43c190aadfd728838c21e3b393a4cdf5958e75871b9bad06551440cb5cbb4d1053efd78b897d005f3eaafc53bed3de14e321d25801bdd529bcb9968830d3ff3bf6f52d39d21c3d29ecb622c93c7c3d49c0053fd8d937f3859afc8ee9fbe77a8d15a4fc3e91627e0eddeb8f8b4ab47d897d340d62dcd286997d6ad60db9dbef43afa31fa0f08faea1494d06435486c55675912e86ea846a89831ca07c2de67b7f4f3636e13f88f0f6ce78f55b5ae95a1ad91a5a206fe68016346035fa080d1913e0b064115d405b7f8f061b2c88f926a8131fc9c53ae0c4dd130ea7ada48f04c2d6bbf6f0c0bc4d6a4d42765d6c99626e4a48a57b3b27165cfea3933f25fd3a1c2bbdae1c3697bd4a453f45c1bf9f59058c06c1bf9f57e9fd5eeb4b813e38810a49c657d7e55c7ed39ab6ef30e494eda9510a886e14c7f81662c4f3a103645dd4436cde2043db875fd8dc491e9be3ba64b955757eba890a21d2b36a181e4823d2b36a168e22d476751100687983f0ff6fd8cad3c23f315c524419c5dc1e6494985b5037e1f43f75d26ce3238e15a1f552f6ba6159e067fd9ab5d6e506e22d0d1830e866294647b2b4fc497b5e7c96d515efafff3ca38558ef78582e9078aff4651da8d80489fb3b2f02f471f077057111b17169cae02381c5d41529d95b3b4e680fb5107b78a5e7ef4948cd1c635b5bc175f2561154583ca31d971cf6008514450cd60aeb196b6aac633122d28c1ae594b8ccb11f18b13a92fedf844ddd095998f07cfa3127d98805d582c726171339f7103a618aca2abb1cb580242472e91f5734497ebe16f1639cc33e81e4823f46dc5f3e209f2328cf623a7be6a1cba9630725196f0d0e1b4dc05c0288e9ba56b737b65a829a134ed1d35f92250e8a6e8ac03a10f9449144dd2b8ed0913af310c341874a2da33ec01f93f62c6d32ffb76b0f148eac32282bdf770624b1eea8a48a6011d5cbe8a8https://github.com/openstyles/stylus into dev-exclusions
commit 5cbe8a8d78#507 )
commit 9058c06c541f2d116aae918e47b1ed81a7bb9ac9f47d57aea85778d5c858268e1716b4cc2980b64708adcb60f26909c732fd531ee4135ce35d39a6d1909f6909c73c6979833d8bbaa849fd6ddad5ee31a0807b959af3e3fefa987c4d2abbf670d81fe0586b29ab0ef239cfd5ade807f04f5337e51d29b8f51292a7cfeb22e49713c6a3be3c30bc3eb03d32b0428b7d75dd8754a4df641b968028a3529fba5d6cc31ab853be13f8a3e79151995d07a8cd4ea004bc3c7d41ac66a137ffb13bf1db42e97ef15364aa9fcf53b0e407e98f7a24547e098a6011de8c4fcb1a88d7bfe54ab4c4983a7bc2193950482f34e94c7edb382b4a1a56359f75b69cd868dfa0153cCloses #113
* Revert: exclusions
* Fix: pass eslint
* Fix: the style is injected twice
* Fix: don't load script async
* Fix: styleCodeEmpty returns true for empty string
* Fix: drop array selection
* Fix: the config dialog is broken
* Fix: popup doesn't use getStyle/getStylesByUrl correctly
* Fix: keep disabled state in setStyleContent
* Fix: allow live-preview to assign newest vars
* Fix: transition fix is broken because setStyleContent becomes async
* Fix: typo, TypeError in styleExists
* Fix: use new API
* Fix: pass linter
* Fix: LICENCE -> LICENSE
* Fix: remove unused distroy function
2018-11-07 14:09:29 +08:00
eight
5cbe8a8d78
Add: fetch style object from DB directly in the editor ( #507 )
2018-10-02 20:22:18 +08:00
eight
2fd531e253
Rewrite linter system ( #487 )
...
* Add: implement new linter system
* Refactor: pull out editor worker
* Switch to new linter and worker
* Enable eslint cache
* Fix: undefined error
* Windows compatibility
* Fix: refresh linter if the editor.linter changes
* Add: stylelint
* Add: getStylelintRules, getCsslintRules
* Fix: logic to get correct linter
* WIP: linter-report
* Fix: toggle hidden state
* Add: matain the order of lint report for section editor
* Add: unhook event
* Add: gotoLintIssue
* Fix: shouldn't delete rule.init
* Add: linter-help-dialog
* Drop linterConfig
* Add: linter-config-dialog, cacheFn
* Add: use cacheFn
* Drop lint.js
* Add: refresh. Fix report order
* Fix: hide empty table
* Add: updateCount. Fix table caption
* Switch to new linter/worker
* Fix: remove unneeded comment
* Fix: cacheFn -> cacheFirstCall
* Fix: use cacheFirstCall
* Fix: cache metaIndex
* Fix: i < trs.length
* Fix: drop isEmpty
* Fix: expose some simple states to global
* Fix: return object code style
* Fix: use proxy to reflect API
* Fix: eslint-disable-line -> eslint-disable-next-line
* Fix: requestId -> id
* Fix: one-liner
* Fix: one-liner
* Fix: move dom event block to top
* Fix: pending -> pendingResponse
* Fix: onSuccess -> onUpdated
* Fix: optimize row removing when i === 0
* Fix: hook/unhook -> enableForEditor/disableForEditor
* Fix: linter.refresh -> linter.run
* Fix: some shadowing
* Fix: simplify getAnnotations
* Fix: cacheFirstCall -> memoize
* Fix: table.update -> table.updateCaption
* Fix: unneeded reassign
* Fix: callbacks -> listeners
* Fix: don't compose but extend
* Refactor: replace linter modules with linter-defaults and linter-engines
* Fix: implement linter fallbacks
* Fix: linter.onChange -> linter.onLintingUpdated
* Fix: cms -> tables
* Fix: parseMozFormat is not called correctly
* Move csslint-loader to background
* Fix: watch config changes
* Fix: switch to LINTER_DEFAULTS
* Fix: csslint-loader -> parserlib-loader
2018-10-01 09:03:17 -05:00
tophf
92d6530c8f
simplify listener registration
...
since the function reference is constant, only one listener will be registered
2018-08-07 20:11:11 +03:00
tophf
eff0a7030c
display only style name in the editor tab title
...
"Edit Style" was redundant and made the title unreadable when many tabs were opened.
"Add Style" is still displayed for the new styles.
2018-08-07 19:59:16 +03:00
tophf
5da1e0fb9b
set onbeforeunload only when dirty
...
https://developers.google.com/web/updates/2018/07/page-lifecycle-api#legacy-lifecycle-apis-to-avoid
2018-08-02 20:54:40 +03:00
tophf
0c58783a6c
add buttons to restore, clone, move a section
2018-07-23 21:24:35 +03:00
tophf
4283cc53a7
use the global line wrapping option in moz-export popup
2018-07-22 20:08:13 +03:00
tophf
126d909ca7
use a typical OS order for #help-popup buttons
...
* horizontally centered in Windows
* right-aligned otherwise
2018-07-22 19:55:27 +03:00
tophf
87da06037f
make showCodeMirrorPopup modal
...
closes #437
2018-07-22 19:37:49 +03:00
tophf
e3d1c6588d
prefill new style name with the domain/hostname
...
implements #344
2018-02-14 05:53:35 +03:00
tophf
dc1cd890ee
notify event subscribers when toggling the style via Alt-Enter
2018-01-14 17:40:09 +03:00
