Commit Graph

2826 Commits

Author SHA1 Message Date
tophf
001db9a19f make editor fully clean on saving 2017-12-18 10:27:50 +03:00
tophf
9e11435923 make editor permanently dirty when a section is deleted 2017-12-18 10:27:50 +03:00
tophf
4a924d6aa8 add 'textarea' to focusAccessibility.ELEMENTS 2017-12-18 10:27:50 +03:00
tophf
5aba0377a0 use helper's decisions in colorview renderer 2017-12-18 10:27:50 +03:00
tophf
50d3dbe394 expose prefs.defaults 2017-12-18 10:27:50 +03:00
tophf
2c47407afb eslintrc: allow shirt-circuit and ternary expressions 2017-12-18 10:27:50 +03:00
tophf
748b9afdb4 remember last used search text in editor 2017-12-14 11:35:32 +03:00
tophf
cc5a254e01 make multi-section search instantaneous 2017-12-14 11:20:22 +03:00
tophf
49a995afae fixup 1c68ac1a: init the find hook after the original one 2017-12-14 09:27:46 +03:00
tophf
6f81544ebe use a theme-friendly transparent color for the #actions bg 2017-12-14 06:29:23 +03:00
tophf
8dbdbe988f fixup dc126e1b: more adjustments for persistent child in #installed
* use .entry collection instead of installed.children
* adjust CSS counters

also:

* KeyboardEvent#code is checked first now - available since Chrome48 and FF32
* synthetic click event is cancelable, otherwise FF would open the editor in popup
2017-12-14 06:08:28 +03:00
tophf
1283e85a8e update USO style install counter
the USO site reports style installation unconditionally even if you uninstall it in 5 seconds, but we do it only if the style isn't uninstalled during 60 seconds while the popup is open - thus we exclude previewing of styles, which is a very popular use case
2017-12-14 01:46:32 +03:00
tophf
f048649e58 keep scroll position on install/delete 2017-12-14 01:13:16 +03:00
tophf
78c14dd93c also apply styleDeleted/Added to invisible search results 2017-12-14 01:08:05 +03:00
tophf
addc5af96d update locales 2017-12-14 00:13:15 +03:00
tophf
3ee502c3a4 fixup/cosmetics 2017-12-13 23:17:45 +03:00
tophf
4601a136a9 fix the popup width bug in FF when scrollbar is shown
* scrollbar width is not subtracted in FF from the actual width
* in some versions of FF the paddings should be added on both sides
2017-12-13 23:13:35 +03:00
tophf
8265d0c8e4 fixup 6d3cb733: remove trailing comma 2017-12-13 20:14:51 +03:00
tophf
6d3cb73324 "Estimated number of total pages" in the tooltip 2017-12-13 09:34:51 +03:00
tophf
3c2421d875 always scroll to the style on "history back" from editor to manager 2017-12-13 09:19:49 +03:00
tophf
8d9c7acb3c only preserve old style name on update if it was actually customized
We didn't detect that previously and just blindly assumed that a local name is always customized by a user, which is nonsense, obviously. To ensure reliable detection a new property is added to the style object: "originalName". From now on the styles that didn't change their name remotely will be successfully marked as having non-customized names, hence the names will update along with the code. Should be like 99% of styles. As for the remaining 1%, welp, only uninstalling and reinstalling the style anew would switch to the new remote name.
2017-12-13 09:12:54 +03:00
tophf
0fe0423757 prevent freezing of inline search nav pager in some cases 2017-12-13 07:46:28 +03:00
tophf
6ee952f3d3 more things made focusable
* mozilla-format (i) icon
* showHelp() restores original focus
* showHelp's nested confirmation is debounced to enable focusing Yes/No
* RegExp tester tab URLs are focusable now
2017-12-13 07:38:36 +03:00
tophf
fd4300f841 add a wiki link, shorten the USO link, use https everywhere 2017-12-13 07:15:40 +03:00
tophf
9fbe97bfd6
Merge pull request #294 from openstyles/narcolepticinsomniac-accessibility
Hide focus outlines without crippling accessibility, plus buttons
2017-12-13 06:20:30 +03:00
tophf
f9153b96eb make #sections-help icon focusable 2017-12-13 06:19:57 +03:00
narcolepticinsomniac
9b93e3e116
Margin tweak 2017-12-12 22:10:50 -05:00
narcolepticinsomniac
a6c10fe49d
Adjust margins
Removed some redundant fixes. Remaining tweaks were mostly info icons. I also applied a hacky margin for checkbox/label options and `.aligned` select options on edit page. They were too close IMO.
2017-12-12 22:09:51 -05:00
tophf
51ad84e6a9 don't open the homepage on first install as it's not helpful
see #112
2017-12-13 05:35:02 +03:00
tophf
7519b38df5 adjust some margins 2017-12-13 05:28:31 +03:00
tophf
a03809e68e make applies-to-help icon focusable 2017-12-13 04:00:05 +03:00
tophf
fefe82fd54 remove what-input, use own implementation, rebase on master 2017-12-13 03:27:10 +03:00
Rob Garrison
2cdd264780 fixups
Manage: Disable tabindex in nested buttons
Manage: Fix homepage link alignment
Manage: Make entry actions keyboard navigatable
Manage: Add search help accessibility
Msgbox: Save and restore focus
Manage: Fix delete confirmation cancel
Manage: Make history button accessible
Manage: Make favicons dropdown accessible
Manage: Prevent focus on hidden textarea
Msgbox: Stop tabbing outside of msgbox
Usercss: Make nondefault reset accessible
Usercss: Make colorpicker accessible
Edit: Disable tabindex in nested buttons
Edit: Make info and config icons accessible
Options: Cleanup HTML
Options: Make advanced toggle accessible
Edit: Fix issues popup
Edit: Remove link underlines from icons
2017-12-12 21:40:31 +03:00
narcolepticinsomniac
e2842f69c3 Hide focus outlines without crippling a11y, plus active state change for buttons 2017-12-12 21:39:55 +03:00
tophf
56c1476e67 code cosmetics 2017-12-12 17:35:38 +03:00
tophf
3ffbce0bc7 adapt to #installed having a persistent child now 2017-12-12 17:09:42 +03:00
narcolepticinsomniac
dc126e1b58 Popup overflow (#302) 2017-12-12 17:04:58 +03:00
tophf
ad692d4f61 chrome.contextMenus.update bug is fixed in Chrome 65.0.3289
#272
2017-12-12 06:20:07 +03:00
tophf
bb8dc04954 re-add #no-styles when inline-search deletes the last one 2017-12-12 05:21:06 +03:00
tophf
5452979366 simplify the options page 2017-12-12 04:20:51 +03:00
tophf
510ae91ac0 don't insert ­ before whitespace 2017-12-12 03:18:37 +03:00
tophf
c23e192b7a bump version 2017-12-11 23:58:01 +03:00
tophf
dc535ee509 update locales 2017-12-11 23:57:00 +03:00
tophf
c3d9e8030b typos and code cosmetics 2017-12-11 23:45:42 +03:00
tophf
50b489478c prefetch next page on scroll past midpage 2017-12-11 23:25:41 +03:00
tophf
0390a703af restore findStylesForSite to avoid retranslation 2017-12-11 23:25:03 +03:00
tophf
3410a58cd9 don't add ­ on word boundaries and strip it from tooltips
addresses #300
2017-12-11 22:39:22 +03:00
tophf
23733bd9fe show 'Style installed' in search result after inline install 2017-12-11 22:26:33 +03:00
tophf
866f54c307 code cosmetics 2017-12-11 13:26:07 +03:00
tophf
1d9ec09d62 simplify inline search DOM structure 2017-12-11 13:03:03 +03:00