Commit Graph

2256 Commits

Author SHA1 Message Date
tophf
8d9c7acb3c only preserve old style name on update if it was actually customized
We didn't detect that previously and just blindly assumed that a local name is always customized by a user, which is nonsense, obviously. To ensure reliable detection a new property is added to the style object: "originalName". From now on the styles that didn't change their name remotely will be successfully marked as having non-customized names, hence the names will update along with the code. Should be like 99% of styles. As for the remaining 1%, welp, only uninstalling and reinstalling the style anew would switch to the new remote name.
2017-12-13 09:12:54 +03:00
tophf
0fe0423757 prevent freezing of inline search nav pager in some cases 2017-12-13 07:46:28 +03:00
tophf
6ee952f3d3 more things made focusable
* mozilla-format (i) icon
* showHelp() restores original focus
* showHelp's nested confirmation is debounced to enable focusing Yes/No
* RegExp tester tab URLs are focusable now
2017-12-13 07:38:36 +03:00
tophf
fd4300f841 add a wiki link, shorten the USO link, use https everywhere 2017-12-13 07:15:40 +03:00
tophf
9fbe97bfd6
Merge pull request #294 from openstyles/narcolepticinsomniac-accessibility
Hide focus outlines without crippling accessibility, plus buttons
2017-12-13 06:20:30 +03:00
tophf
f9153b96eb make #sections-help icon focusable 2017-12-13 06:19:57 +03:00
narcolepticinsomniac
9b93e3e116
Margin tweak 2017-12-12 22:10:50 -05:00
narcolepticinsomniac
a6c10fe49d
Adjust margins
Removed some redundant fixes. Remaining tweaks were mostly info icons. I also applied a hacky margin for checkbox/label options and `.aligned` select options on edit page. They were too close IMO.
2017-12-12 22:09:51 -05:00
tophf
51ad84e6a9 don't open the homepage on first install as it's not helpful
see #112
2017-12-13 05:35:02 +03:00
tophf
7519b38df5 adjust some margins 2017-12-13 05:28:31 +03:00
tophf
a03809e68e make applies-to-help icon focusable 2017-12-13 04:00:05 +03:00
tophf
fefe82fd54 remove what-input, use own implementation, rebase on master 2017-12-13 03:27:10 +03:00
Rob Garrison
2cdd264780 fixups
Manage: Disable tabindex in nested buttons
Manage: Fix homepage link alignment
Manage: Make entry actions keyboard navigatable
Manage: Add search help accessibility
Msgbox: Save and restore focus
Manage: Fix delete confirmation cancel
Manage: Make history button accessible
Manage: Make favicons dropdown accessible
Manage: Prevent focus on hidden textarea
Msgbox: Stop tabbing outside of msgbox
Usercss: Make nondefault reset accessible
Usercss: Make colorpicker accessible
Edit: Disable tabindex in nested buttons
Edit: Make info and config icons accessible
Options: Cleanup HTML
Options: Make advanced toggle accessible
Edit: Fix issues popup
Edit: Remove link underlines from icons
2017-12-12 21:40:31 +03:00
narcolepticinsomniac
e2842f69c3 Hide focus outlines without crippling a11y, plus active state change for buttons 2017-12-12 21:39:55 +03:00
tophf
56c1476e67 code cosmetics 2017-12-12 17:35:38 +03:00
tophf
3ffbce0bc7 adapt to #installed having a persistent child now 2017-12-12 17:09:42 +03:00
narcolepticinsomniac
dc126e1b58 Popup overflow (#302) 2017-12-12 17:04:58 +03:00
tophf
ad692d4f61 chrome.contextMenus.update bug is fixed in Chrome 65.0.3289
#272
2017-12-12 06:20:07 +03:00
tophf
bb8dc04954 re-add #no-styles when inline-search deletes the last one 2017-12-12 05:21:06 +03:00
tophf
5452979366 simplify the options page 2017-12-12 04:20:51 +03:00
tophf
510ae91ac0 don't insert ­ before whitespace 2017-12-12 03:18:37 +03:00
tophf
c23e192b7a bump version 2017-12-11 23:58:01 +03:00
tophf
dc535ee509 update locales 2017-12-11 23:57:00 +03:00
tophf
c3d9e8030b typos and code cosmetics 2017-12-11 23:45:42 +03:00
tophf
50b489478c prefetch next page on scroll past midpage 2017-12-11 23:25:41 +03:00
tophf
0390a703af restore findStylesForSite to avoid retranslation 2017-12-11 23:25:03 +03:00
tophf
3410a58cd9 don't add ­ on word boundaries and strip it from tooltips
addresses #300
2017-12-11 22:39:22 +03:00
tophf
23733bd9fe show 'Style installed' in search result after inline install 2017-12-11 22:26:33 +03:00
tophf
866f54c307 code cosmetics 2017-12-11 13:26:07 +03:00
tophf
1d9ec09d62 simplify inline search DOM structure 2017-12-11 13:03:03 +03:00
tophf
3a82a66954 open editor a bit faster, fixup <select> bug and widget style 2017-12-11 09:12:56 +03:00
tophf
1b19cc0cf6 import report shouldn't alter #header 2017-12-11 08:44:41 +03:00
tophf
fb29638d00 defocus codemirror on Esc 2017-12-11 08:32:27 +03:00
tophf
60a5fb96be don't steal focus from the find input on page open 2017-12-11 08:32:11 +03:00
tophf
180e813ac4 tweak spinner opacity 2017-12-11 08:31:15 +03:00
tophf
752af458a3 redesign inline search cards 2017-12-11 07:35:23 +03:00
tophf
f4bfeea5a6 intermediate tweaks and fixes for inline search
* caching of search results and downloaded style info for one day
* no prefetching of styles
* only the next search results page is prefetched in unattended fashion
* the "configure" button is shown only after installation
* join the code in one closure, regroup and simplify some functions
2017-12-11 05:21:23 +03:00
tophf
adabb9aeff use LZString alias for LZStringUnsafe 2017-12-11 04:49:59 +03:00
tophf
b9c6be1676 disable the useless no-unmodified-loop-condition rule 2017-12-11 04:46:33 +03:00
tophf
f44ed87646 use a thin underline under big bold titles in inline search 2017-12-10 12:00:40 +03:00
tophf
6fb9d2d157 switch to a much faster LZStringUnsafe
https://github.com/pieroxy/lz-string/pull/98
2017-12-10 11:30:57 +03:00
tophf
8679e55206 unregister listeners on closing showCodeMirrorPopup 2017-12-10 11:24:52 +03:00
tophf
baab837be4 adjust style properties on installing
* reason = 'install'
* updateUrl += '?' when configurable
2017-12-10 10:56:09 +03:00
tophf
f120ae9753 fixup 0a865318: preserve normal behavior on normal links 2017-12-10 10:49:34 +03:00
tophf
b365962bbf don't scroll search list into view in old FF
couldn't find the reason in a couple minutes I can waste on this
2017-12-10 10:42:03 +03:00
tophf
888f93281d reduce DOM thrashing in adjustInfoPosition 2017-12-10 10:29:04 +03:00
tophf
abc4923059 cache search results for 1 hour 2017-12-10 10:11:19 +03:00
tophf
780053a19e darken search result description 2017-12-10 10:11:19 +03:00
tophf
d035e18b9f expose responseType in download() 2017-12-10 10:11:19 +03:00
tophf
405400de68 move 'tempUsercssCode' cleanup to usercss helper 2017-12-10 10:11:18 +03:00