* move updates/sync to the top, theme to the bottom
* remove font override
* replace 'Back to manage' with 'Close'
* add a note for the built-in shortcuts UI in FF
- update button
+ confirm reset
* one button to connect/disconnect
* shorten ids
* simplify/extract sync js
* reuse :invalid style
+ simplify css/html
+ save button and autosave checkbox just like in config-dialog
+ generalize can-close-on-esc
+ add `props` parameter to helpPopup.show
+ deduplicate usage of #help-popup id
+ uniform padding in popups
+ disambiguate style settings from editor options
* Add: style settings
* Change: use radio instead of select for dark/light mode
* Change: x -> Delete
* Change: (in|ex)clusion messages
* Fix: avoid extra space when there is no rule
* Fix: UI in mobile
* Change: delete priority
* Change: use textarea for include/exclude, remove isCodeUpdated
* Fix: separate toggle
* Fix: minor
* Fix: remove codeIsUpdated in styleman
* shortened the title to "Publish" and fixed the compact mode
* made collapsed <details> share the same line in compact mode
* made hard-coded strings localizable
* IIFE modules instead of generically named globals
* unified and sorted the names of localized messages
* adjusted spacing of header items
* center auth popup to current window
Co-authored-by: Gusted <williamzijl7@hotmail.com>
* improve linter info popup
* show rule id so the user can configure it
* add "configure" button to show the linter config UI
* add margins between items
* emphasize active rules in linter config dialog
* section labels, TOC, speedups and fixes
* show section numbers in widgets
* debounce livePreview in usercss editor
* better fixed header and compact layout compatibility
* fix section sizing for compact layout + layout speedup
* DocFuncMapper + cosmetics + fix Clone button
* don't run linter during initSections
* remove unused/unnecessary DOM polyfills
* report invalid @document function as parser error
* rewrite section finder
* simplify focusedViaClick
* simplify setPreprocessor and make it synchronous
* throttle offscreen line widgets in usercss with lots of sections
* add on, off aliases for add/removeEventListener + onOff
* use on/off aliases in changed files
* use getters in more places
* also apply live-preview if an unsaved style was disabled
* use box-shadow instead of outline for focus everywhere
* allow focus outline on click in text/search input or textarea
* search inputs should use the same style as text inputs
* also use box-shadow focus on delete buttons
* remove URLSearchParams workaround, not needed since Chrome 55
* use `once` in addEventListener, available since Chrome 55
* update USO bug workarounds, remove obsolete ones
* ping/pong to fix openURL with `message` in FF
* use unprefixed CSS filter, available since Chrome 53
* use unprefixed CSS user-select, available since Chrome 54
* focus tweaks
* also use text query in inline search for Stylus category
* use event.key, available since Chrome 51
Co-authored-by: narcolepticinsomniac
* make usercss editor full-height again
* make sectioned editor open quickly again
* remove leftovers
* autofocus when add/clone button is clicked
* don't fit to content on clicking the add button
* scroll the window to show a manually added section entirely
* autofocus on a manually added applies-to
* disable Save button while loading
* use standard CSS for a focused CodeMirror outline
* trigger refresh sooner by one viewport in advance
* declare refreshOnView as a standard function
* run fixedHeader asynchronously to prevent self-triggering
* account for header in compact mode when fitting to content
* code cosmetics
* linter and compact layout improvements
Closes#748
While investigating the best way to fix linter scrolling, when I double-checked the compact layout, an old bug I meant to fix a long time ago was immediately apparent. Basically, the linter adds/removes errors as you type, causing the editor to bounce up and down, making it practically unusable.
This PR fixes scrolling, and also collapses options and the linter in the compact layout, but always shows the collapsed linter so you're aware of the error count without the content jumping. It also collapses options in the non-compact layout if the viewport is too short to accommodate them, factoring in the min-height of the linter. All automatic collapsing factors in whether a linter is active so they can adjust accordingly, and disables the setting of collapsed state prefs, since we're deciding the pref anyway, and this allows for re-expanding on resize based on the previous pref.
It's quite possible I failed to account for certain scenarios, so try to break it. Also think it's problematic for the linter to not always be visible if enabled, so I hooked up a 40px fixed header on scroll with just the linter in it for the compact layout.
A few other little details are included. I removed redundant line and column numbers spelled out at the end of lint messages to prevent horizontal overflow. I noticed that the expand/collapse prefs do not toggle correctly when clicking directly on the details-marker arrow. Simplest solution was covering them with the `h2` (we may wanna hook up the manager as well). Also, unrelated, but I switched to opacity to hide resizing sectioned editors, because `visibility: hidden;` breaks editor auto-focus.
If either of you guys wanna fix any bugs, or improve any code, feel free to just commit to this PR directly.
* linter and compact layout improvements
* linter and compact layout improvements
* No usercss scroll listener and delay header check
* Some code tweaks
* Add: auto resize section editor on init
* Fix: calculate cm height correctly
* Fix: query heights before set
* Fix: work with small layout, hide sections before ready
* Fix search highlight conflict
Regular highlight styling and search highlight styling shouldn't both be applied at the same time. Search highlight styling should also be removed when search is closed. This PR resolves those conflicts.
* Remove unnecessary dummy animation
Not sure what the point of it ever was, but I'm pretty sure it should go.
