tophf
6ee952f3d3
more things made focusable
...
* mozilla-format (i) icon
* showHelp() restores original focus
* showHelp's nested confirmation is debounced to enable focusing Yes/No
* RegExp tester tab URLs are focusable now
2017-12-13 07:38:36 +03:00
narcolepticinsomniac
a6c10fe49d
Adjust margins
...
Removed some redundant fixes. Remaining tweaks were mostly info icons. I also applied a hacky margin for checkbox/label options and `.aligned` select options on edit page. They were too close IMO.
2017-12-12 22:09:51 -05:00
tophf
fefe82fd54
remove what-input, use own implementation, rebase on master
2017-12-13 03:27:10 +03:00
Rob Garrison
2cdd264780
fixups
...
Manage: Disable tabindex in nested buttons
Manage: Fix homepage link alignment
Manage: Make entry actions keyboard navigatable
Manage: Add search help accessibility
Msgbox: Save and restore focus
Manage: Fix delete confirmation cancel
Manage: Make history button accessible
Manage: Make favicons dropdown accessible
Manage: Prevent focus on hidden textarea
Msgbox: Stop tabbing outside of msgbox
Usercss: Make nondefault reset accessible
Usercss: Make colorpicker accessible
Edit: Disable tabindex in nested buttons
Edit: Make info and config icons accessible
Options: Cleanup HTML
Options: Make advanced toggle accessible
Edit: Fix issues popup
Edit: Remove link underlines from icons
2017-12-12 21:40:31 +03:00
narcolepticinsomniac
e2842f69c3
Hide focus outlines without crippling a11y, plus active state change for buttons
2017-12-12 21:39:55 +03:00
tophf
3a82a66954
open editor a bit faster, fixup <select> bug and widget style
2017-12-11 09:12:56 +03:00
tophf
fb29638d00
defocus codemirror on Esc
2017-12-11 08:32:27 +03:00
tophf
60a5fb96be
don't steal focus from the find input on page open
2017-12-11 08:32:11 +03:00
tophf
8679e55206
unregister listeners on closing showCodeMirrorPopup
2017-12-10 11:24:52 +03:00
tophf
db8c3585dd
off-by-one in showKeyMapHelp: text after <mark> was lost
2017-12-09 20:43:47 +03:00
tophf
f11235aaf9
Revert 1e1ff736 "simplify theme preloader"
2017-12-09 19:05:44 +03:00
tophf
443e3a3c7c
second lockPageUI runs after there's no codebox anymore
2017-12-09 19:05:00 +03:00
tophf
ab98d46baa
show import errors in messageBox
2017-12-09 19:04:19 +03:00
tophf
5f1f9c4d86
unregister CM on closing showCodeMirrorPopup
2017-12-09 18:23:18 +03:00
tophf
5faff66fab
fix cross-section cursor navigation via keyboard
2017-12-08 11:42:33 +03:00
tophf
1c68ac1a3a
initialize editor page fully in First Meaningful Paint frame
...
* previously it wasn't the case when colorpicker option was enabled
* the cost of always loading colorview is ~1ms for >200ms here
2017-12-08 06:20:56 +03:00
narcolepticinsomniac
ce47e69b8a
Custom UI elements ( #291 )
2017-12-08 06:18:47 +03:00
tophf
99cce55a8e
ensure long words break before breaking the layout
...
supersedes 40075a0d
2017-12-07 23:21:27 +03:00
tophf
6a838e9d5e
make sure all pre-create hooks finished
2017-12-07 20:26:41 +03:00
tophf
7a07ee9fd9
unbreak narrow editor layout
2017-12-07 05:31:42 +03:00
tophf
9c8e835a80
relay scrolling over #header to usercss code section
2017-12-07 04:36:46 +03:00
tophf
d4ffa04bb6
raise applies-to widget above .CodeMirror-activeline
2017-12-07 04:00:26 +03:00
tophf
ebef35c28c
drop linter name from "see all rules" and make it a link
2017-12-07 01:21:05 +03:00
tophf
d998fb235a
center editor config icons
2017-12-07 01:20:04 +03:00
tophf
8f9705c165
recognize USO vars ending with -rgb
2017-12-06 06:34:02 +03:00
tophf
44ce51e54f
dim regexp-tester note and avoid extending the report width
2017-12-05 22:12:04 +03:00
tophf
61003b378c
usercss editor: show all section regexps in tester
2017-12-05 21:52:24 +03:00
tophf
963930ea1d
usercss editor: restore "Add" and "Regexp test", convert \ in regexps
2017-12-05 21:32:28 +03:00
tophf
bd0f460c56
usercss editor: use real theme color for inputs in widgets
2017-12-05 21:01:32 +03:00
tophf
edfca7bfed
match-highlighter-helper: do nothing when disabled
2017-12-05 07:40:28 +03:00
tophf
3e34c77625
clear previous token/selection highlight from scrollbar
2017-12-05 05:40:33 +03:00
tophf
8e992299c6
clear previous search highlight from scrollbar in all sections
2017-12-05 05:40:27 +03:00
tophf
cb7f1de348
use hyphens when breaking words (works only in FF though)
2017-12-05 05:02:28 +03:00
tophf
40075a0d39
forcefully break long labels in aligned options
2017-12-05 04:39:29 +03:00
tophf
1e1ff73612
simplify theme preloader
2017-12-05 04:39:29 +03:00
tophf
a6f63d096e
extract checkboxes to global.css, fixes
2017-12-05 04:39:29 +03:00
narcolepticinsomniac
7339643ec3
Custom checkbox and select elements
2017-12-05 04:39:29 +03:00
tophf
3e9810678a
fixup 0e61de29: use break/continue instead of return
...
fixes #282
2017-12-04 20:13:56 +03:00
tophf
01e8c3b080
disable spellchecking in input fields
2017-12-04 09:00:14 +03:00
tophf
48dda41e2e
fixup 99512da9 and 493c1a65: show csslint rule info in issues info box
2017-12-04 08:57:12 +03:00
tophf
c0c60fb7a2
add a terse invocation syntax for $element and rename it to $create
2017-12-04 08:57:12 +03:00
tophf
e905e4e079
properly escape/unescape regexp in applies-to widgets
2017-12-03 22:51:03 +03:00
tophf
489546e35c
use just one event listener per applies-to widget in usercss editor
2017-12-03 21:21:51 +03:00
tophf
f4677a7b7b
actually use the name when saving
2017-12-03 20:32:50 +03:00
tophf
9314fa0e8a
fixup 0e61de29: register the listener before setupLivePrefs()
2017-12-03 04:18:58 +03:00
tophf
8622dffe1e
usercss: make nextPrevMozDocument work with minified CSS
2017-12-03 04:05:35 +03:00
tophf
43fc26619d
editor: raise highlight limit from 10k to 100k chars in one line
2017-12-03 02:02:22 +03:00
tophf
a5c3c2e895
editor: use 'editor.lineWrapping' option on opening
2017-12-03 01:52:46 +03:00
tophf
904e6017f2
close showHelp() if input element has can-close-on-esc class
2017-12-03 00:22:03 +03:00
tophf
a5f31162f6
de-htmlize showKeymapHelp
2017-12-03 00:20:42 +03:00
tophf
0e61de2920
edit.js: pull out hooks, sections, keymap help, beautify
...
just a simple preparation for a proper encapsulation in the future
2017-12-02 23:46:00 +03:00
tophf
0de69e306d
code refactor: add $.remove() and $$.remove()
2017-12-02 19:54:54 +03:00
tophf
0ba3cfb725
FF: fix transition-bug-suppressor condition
2017-12-02 19:38:03 +03:00
tophf
e32fecd1e3
usercss: tint the active line's @mozdoc widget
2017-12-02 18:53:37 +03:00
tophf
fbd7526092
usercss: Alt-PgUp/PgDn go to prev/next @-moz-document
2017-12-02 18:29:12 +03:00
tophf
d263bc8e55
disallow more nav keys in colorpicker hotkey config dialog
2017-12-02 17:15:55 +03:00
tophf
5bdaacc049
stabilize token highlighting for the match/search mode
2017-12-01 21:16:19 +03:00
tophf
2760b0764b
fixup b41cc8bc: only rewrite query if regexp
2017-12-01 16:22:43 +03:00
tophf
bf8d33a3f4
followup for a60d53de: move #footer down when #lint is collapsed
2017-12-01 06:17:24 +03:00
tophf
b41cc8bca3
4x speed-up of showMatchesOnScrollbar
...
at the cost of a marginally reduced accuracy when line wrapping is enabled, but the difference shouldn't be more than a few pixels, presumably
2017-12-01 05:14:52 +03:00
tophf
a6fbc9db11
render lint squigglies 4x faster
...
* turns out codemirror lint addon doesn't open an overall op,
instead it creates an op for each marker.
* also, now there's no need to disable the lint option when initializing codemirror
2017-12-01 03:49:09 +03:00
tophf
71f3dfbffd
usercss: don't relint on save; mode is an object once initialized
2017-11-30 20:42:52 +03:00
tophf
a60d53de29
edit: workaround for <details> not showing the toggle
2017-11-29 19:27:31 +03:00
tophf
189342472e
manage: collapsible #options block
2017-11-29 19:27:31 +03:00
tophf
fc0b1dc739
fixup 493c1a65: missed some null checks and a return
2017-11-29 17:59:00 +03:00
tophf
be633bf903
usercss: update URL and sessionStorage on replacing the style
2017-11-29 13:35:27 +03:00
tophf
260cbddae0
usercss: force-refresh codemirror on saving to repaint vars
2017-11-29 13:27:55 +03:00
tophf
b995a9d316
usercssData.vars may be absent (e.g. in unsaved style)
...
fixes #267
2017-11-29 13:24:13 +03:00
tophf
bf13383c93
workaround for URLSearchParams not stripping "?" in chrome 49-51
2017-11-28 22:19:00 +03:00
tophf
39c6d897ed
mozImport: show hotkey in button tooltip
2017-11-28 20:07:38 +03:00
tophf
d39e9f6037
show most of the sidebar in big codemirror popups
2017-11-28 20:07:38 +03:00
tophf
493c1a65c0
worker for stylelint; hints in linter config popup
2017-11-28 20:07:37 +03:00
tophf
99512da9da
use CSSLint in a web werkker
2017-11-27 17:02:30 +03:00
tophf
761f6a5085
fix an ancient bug with setting tabSize option to a string
2017-11-27 14:54:19 +03:00
tophf
d660e6bd72
usercss validator: more precise error position report
2017-11-27 14:54:18 +03:00
tophf
a603cc081b
use the same "configure" icon in editor an manager
2017-11-27 14:53:34 +03:00
tophf
13d7e30a75
usercss saving: display errors from mozparser in <pre>
2017-11-27 06:55:12 +03:00
tophf
8d3fd9cc3b
fixups for a58f42de (backtick) and 05677d93 (copy changed meta)
2017-11-27 03:19:31 +03:00
tophf
841e556f42
calc an actual per-item height even though CM doesn't seem to care
2017-11-27 02:59:44 +03:00
tophf
170bd0ccb1
reuse line index cache for posFromIndex
...
100ms -> 50ms rendering time in updateInvisible() for "RU AdList CSS Fixes" style
300ms -> 50ms is the final speedup with the widget height cache in 3fd4343c
2017-11-27 02:43:10 +03:00
eight
5dbd2249dd
Add: use cache template
2017-11-27 02:43:10 +03:00
tophf
3fd4343cfd
usercss: don't recalc widget height => spend 0 time in CM
...
300ms -> 100ms rendering time in updateInvisible() for "RU AdList CSS Fixes" style
2017-11-27 01:33:16 +03:00
tophf
05677d93b3
usercss: use cm.changeGeneration() to detect dirtiness
2017-11-27 00:57:25 +03:00
tophf
a58f42dee0
usercss editor: save as template when @name is empty
...
* reduced the flickering on page open
* show * in title for new styles
* align the values in the default template
* don't ask to save an untouched template
* don't spam the console with errors
* trivial code refactor and cosmetics
2017-11-26 18:43:40 +03:00
tophf
af64ec4ac0
show a real hotkey in Save button tooltip
2017-11-26 15:08:47 +03:00
tophf
74e6ea5a56
fixup c8c02805: +1 only when no previous widget found
2017-11-26 05:10:31 +03:00
tophf
c8c02805f4
fixup 82651ed6: recreate widgets for active line if needed
2017-11-25 17:44:32 +03:00
tophf
8f04e17d27
fix #223 - Android compatibility
2017-11-25 16:25:20 +03:00
tophf
febaefd8dc
don't show autocomplete on numbers
2017-11-25 04:30:19 +03:00
tophf
3ed98cb506
fixup 80547aef: autocomplete should fallback to original helper
2017-11-25 04:29:56 +03:00
tophf
7c0d8f0841
prevent inline overlays from breaking color swatches
2017-11-24 13:19:19 +03:00
tophf
7e4683d417
USO-vars in CSSLint
2017-11-24 13:19:19 +03:00
tophf
80547aef70
recognize USO-variables /*[[foo]]*/ and provide autocomplete hints
2017-11-24 13:19:18 +03:00
tophf
3152a7ebfe
simpler plain string method for same token check
2017-11-24 13:19:18 +03:00
tophf
8bff4a297e
disallow Space as a colorpicker hotkey
2017-11-24 13:19:17 +03:00
tophf
d2826d92f6
CodeMirror css mode: recognize "isolation"
2017-11-24 13:19:17 +03:00
tophf
c1d1c26c23
CodeMirror css mode: recognize "mix-blend-mode"
2017-11-24 13:19:16 +03:00
tophf
4fc54450b7
de-marginalize usercss editor; fix narrow @media
2017-11-24 13:19:15 +03:00
tophf
74701810b7
remove cruft; silence eslint
2017-11-24 13:19:15 +03:00
tophf
479d95711b
linter report expands/collapses on click; the state is saved
2017-11-24 13:19:15 +03:00
