open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add: fixme comment about openEditor

Browse Source
This commit is contained in:
eight 2020-02-01 04:48:21 +08:00
parent 9c8cb9b928
commit fca1c13a8c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
background/background.js
View File

@ -399,7 +399,6 @@ function onRuntimeMessage(msg, sender) {
return fn.apply(context, msg.args); return fn.apply(context, msg.args);
} }
// FIXME: popup.js also open editor but it doesn't use this API.
function openEditor(params) { function openEditor(params) {
const searchParams = new URLSearchParams(); // FIXME: use url.searchParams when Chrome >= 51 const searchParams = new URLSearchParams(); // FIXME: use url.searchParams when Chrome >= 51
for (const key in params) { for (const key in params) {
@ -408,6 +407,7 @@ function openEditor(params) {
const search = searchParams.toString(); const search = searchParams.toString();
const url = chrome.runtime.getURL('edit.html') + (search && `?${search}`); const url = chrome.runtime.getURL('edit.html') + (search && `?${search}`);
if (chrome.windows && prefs.get('openEditInWindow')) { if (chrome.windows && prefs.get('openEditInWindow')) {
// FIXME: should we reuse the editor window?
chrome.windows.create(Object.assign({url}, prefs.get('windowPosition'))); chrome.windows.create(Object.assign({url}, prefs.get('windowPosition')));
} else { } else {
openURL({url}); openURL({url});