open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: remove unused workaround

Browse Source
This commit is contained in:
eight 2020-02-01 17:54:06 +08:00
parent 73868f1a93
commit fa487bfaba
1 changed files with 2 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
popup/popup.js
View File

@ -534,8 +534,7 @@ Object.assign(handleEvent, {
openEditor(event, options) { openEditor(event, options) {
event.preventDefault(); event.preventDefault();
API.openEditor(options); API.openEditor(options);
// FIXME: why do we want to avoid window.close here? window.close();
if (!(FIREFOX && prefs.get('openEditInWindow'))) window.close();
}, },
maybeEdit(event) { maybeEdit(event) {
@ -574,15 +573,7 @@ Object.assign(handleEvent, {
.then(() => msg.sendTab(tab.id, message)); .then(() => msg.sendTab(tab.id, message));
} }
}) })
.then(() => { .then(window.close);
// Chromium needs help closing popup when opening new windows, not same window tabs
// FF needs help closing popup when opening same window tabs, not new windows
// edit URLs are ignored by pref - manager URls are passed to openURL() to check if tab exists
// which sends a message to close popup after determining it's not a different FF window
// because closing popup interferes with activating different windows in FF
// FIXME: the popup won't be closed after clicking "Open manager" button
if (this.dataset.href !== 'manage.html') window.close();
});
}, },
openManager(event) { openManager(event) {