open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix: dead object

Browse Source
This commit is contained in:
eight 2018-10-12 16:39:47 +08:00
parent 5ae95a1ad9
commit f6ce78f55b
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/msg.js
View File

@ -10,7 +10,8 @@ const msg = (() => {
window._msg = { window._msg = {
id: 1, id: 1,
storage: new Map(), storage: new Map(),
handler: null handler: null,
clone: deepCopy
}; };
} }
const runtimeSend = promisify(chrome.runtime.sendMessage.bind(chrome.runtime)); const runtimeSend = promisify(chrome.runtime.sendMessage.bind(chrome.runtime));
@ -77,8 +78,9 @@ const msg = (() => {
throw new Error('there is no bg handler'); throw new Error('there is no bg handler');
} }
const handlers = bg._msg.handler.extension.concat(bg._msg.handler.both); const handlers = bg._msg.handler.extension.concat(bg._msg.handler.both);
// FIXME: do we want to deepCopy `data`? // in FF, the object would become a dead object when the window
return Promise.resolve(executeCallbacks(handlers, data, {url: location.href})) // is closed, so we have to clone the object into background.
return Promise.resolve(executeCallbacks(handlers, bg._msg.clone(data), {url: location.href}))
.then(deepCopy); .then(deepCopy);
} }
return send(data); return send(data);