open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

silence some useless warnings in console

Browse Source
This commit is contained in:
tophf 2017-11-25 21:47:02 +03:00
parent fc0b1dc739
commit cbe90272b9
2 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
background/background.js
View File

@ -317,11 +317,13 @@ function updateIcon(tab, styles) {
} }
// Vivaldi bug workaround: setBadgeText must follow setBadgeBackgroundColor // Vivaldi bug workaround: setBadgeText must follow setBadgeBackgroundColor
chrome.browserAction.setBadgeBackgroundColor({color}); chrome.browserAction.setBadgeBackgroundColor({color});
getTab(tab.id).then(realTab => { setTimeout(() => {
// skip pre-rendered tabs getTab(tab.id).then(realTab => {
if (realTab.index >= 0) { // skip pre-rendered tabs
chrome.browserAction.setBadgeText({text, tabId: tab.id}); if (realTab.index >= 0) {
} chrome.browserAction.setBadgeText({text, tabId: tab.id});
}
});
}); });
}); });
} }
@ -376,7 +378,7 @@ function onRuntimeMessage(request, sender, sendResponseInternal) {
case 'closeTab': case 'closeTab':
chrome.tabs.remove(request.tabId || sender.tab.id, () => { chrome.tabs.remove(request.tabId || sender.tab.id, () => {
if (chrome.runtime.lastError) { if (chrome.runtime.lastError && request.tabId !== sender.tab.id) {
sendResponse(new Error(chrome.runtime.lastError.message)); sendResponse(new Error(chrome.runtime.lastError.message));
} }
}); });

6
js/prefs.js
View File

@ -299,7 +299,7 @@ var prefs = new function Prefs() {
// Polyfill for Firefox < 53 https://bugzilla.mozilla.org/show_bug.cgi?id=1220494 // Polyfill for Firefox < 53 https://bugzilla.mozilla.org/show_bug.cgi?id=1220494
function getSync() { function getSync() {
if ('sync' in chrome.storage) { if ('sync' in chrome.storage && !chrome.runtime.id.includes('@temporary')) {
return chrome.storage.sync; return chrome.storage.sync;
} }
const crappyStorage = {}; const crappyStorage = {};
@ -313,7 +313,9 @@ var prefs = new function Prefs() {
crappyStorage[property] = source[property]; crappyStorage[property] = source[property];
} }
} }
callback(); if (typeof callback === 'function') {
callback();
}
} }
}; };
} }