open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix setupLivePrefs regression

Browse Source
This commit is contained in:
tophf 2022-02-17 19:51:58 +03:00
parent 6fb2727f6b
commit c9b8593830
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
js/dom.js
View File

@ -305,11 +305,11 @@ function scrollElementIntoView(element, {invalidMarginRatio = 0} = {}) {
* and establishes a two-way connection between the document elements and the actual prefs * and establishes a two-way connection between the document elements and the actual prefs
*/ */
function setupLivePrefs(ids) { function setupLivePrefs(ids) {
let forceUpdate = true; let init = true;
// getElementsByTagName is cached so it's much faster than calling querySelector for each id // getElementsByTagName is cached so it's much faster than calling querySelector for each id
ids = ids ? [...ids] : prefs.knownKeys.filter(id => id in document.getElementsByTagName('*')); ids = ids ? [...ids] : prefs.knownKeys.filter(id => id in document.getElementsByTagName('*'));
prefs.subscribe(ids, updateElement, {runNow: true}); prefs.subscribe(ids, updateElement, {runNow: true});
forceUpdate = false; init = false;
function onChange() { function onChange() {
if (this.checkValidity() && (this.type !== 'radio' || this.checked)) { if (this.checkValidity() && (this.type !== 'radio' || this.checked)) {
prefs.set(this.id || this.name, getValue(this)); prefs.set(this.id || this.name, getValue(this));
@ -337,7 +337,7 @@ function setupLivePrefs(ids) {
} }
for (const el of els) { for (const el of els) {
const oldValue = getValue(el); const oldValue = getValue(el);
if (!isSame(el, oldValue, value) || forceUpdate) { if (!isSame(el, oldValue, value)) {
if (el.type === 'radio') { if (el.type === 'radio') {
el.checked = value === oldValue; el.checked = value === oldValue;
} else if (el.type === 'checkbox') { } else if (el.type === 'checkbox') {
@ -346,8 +346,8 @@ function setupLivePrefs(ids) {
el.value = value; el.value = value;
} }
el.dispatchEvent(new Event('change', {bubbles: true})); el.dispatchEvent(new Event('change', {bubbles: true}));
if (forceUpdate) el.on('change', onChange);
} }
if (init) el.on('change', onChange);
} }
} }
} }