open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

circumvent the bug with disabling check marks in Chrome 62+

Browse Source 
fixes #272
This commit is contained in:
tophf 2017-12-02 16:06:57 +03:00
parent fdcdaf3db5
commit c11c100cbb
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
background/background.js
View File

@ -147,9 +147,13 @@ if (chrome.contextMenus) {
chrome.contextMenus.create(item, ignoreChromeError); chrome.contextMenus.create(item, ignoreChromeError);
} }
}; };
const toggleCheckmark = (id, checked) => {
chrome.contextMenus.update(id, {checked}, ignoreChromeError); // circumvent the bug with disabling check marks in Chrome 62+
}; // TODO: replace 1e6 with the actual rev. number when/if the bug is fixed
const toggleCheckmark = CHROME >= 3172 && CHROME <= 1e6 ?
(id => chrome.contextMenus.remove(id, () => createContextMenus([id]) + ignoreChromeError())) :
((id, checked) => chrome.contextMenus.update(id, {checked}, ignoreChromeError));
const togglePresence = (id, checked) => { const togglePresence = (id, checked) => {
if (checked) { if (checked) {
createContextMenus([id]); createContextMenus([id]);
@ -157,6 +161,7 @@ if (chrome.contextMenus) {
chrome.contextMenus.remove(id, ignoreChromeError); chrome.contextMenus.remove(id, ignoreChromeError);
} }
}; };
const keys = Object.keys(contextMenus); const keys = Object.keys(contextMenus);
prefs.subscribe(keys.filter(id => typeof prefs.readOnlyValues[id] === 'boolean'), toggleCheckmark); prefs.subscribe(keys.filter(id => typeof prefs.readOnlyValues[id] === 'boolean'), toggleCheckmark);
prefs.subscribe(keys.filter(id => contextMenus[id].presentIf), togglePresence); prefs.subscribe(keys.filter(id => contextMenus[id].presentIf), togglePresence);