Fix: don't self-edit

This commit is contained in:
eight 2019-02-11 12:56:03 +08:00
parent 3cd31c429e
commit b01ba2adae

View File

@ -198,7 +198,7 @@ const styleManager = (() => {
if (data[type].includes(rule)) { if (data[type].includes(rule)) {
throw new Error('The rule already exists'); throw new Error('The rule already exists');
} }
data[type].push(rule); data[type] = data[type].concat([rule]);
return saveStyle(data) return saveStyle(data)
.then(newData => handleSave(newData, 'styleSettings')); .then(newData => handleSave(newData, 'styleSettings'));
} }
@ -208,11 +208,10 @@ const styleManager = (() => {
if (!data[type]) { if (!data[type]) {
return; return;
} }
const index = data[type].indexOf(rule); if (!data[type].includes(rule)) {
if (index < 0) {
return; return;
} }
data[type].splice(index, 1); data[type] = data[type].filter(r => r !== rule);
return saveStyle(data) return saveStyle(data)
.then(newData => handleSave(newData, 'styleSettings')); .then(newData => handleSave(newData, 'styleSettings'));
} }