Fix JS error when this.sender.tab is undefined

This commit is contained in:
Rob Garrison 2019-11-02 08:35:44 -05:00
parent c0fd71dda6
commit a9021f375e

View File

@ -43,6 +43,7 @@ window.API_METHODS = Object.assign(window.API_METHODS || {}, {
openEditor, openEditor,
updateIconBadge(count) { updateIconBadge(count) {
if (this.sender.tab) {
// TODO: remove once our manifest's minimum_chrome_version is 50+ // TODO: remove once our manifest's minimum_chrome_version is 50+
// Chrome 49 doesn't report own extension pages in webNavigation apparently // Chrome 49 doesn't report own extension pages in webNavigation apparently
// so we do a force update which doesn't use the cache. // so we do a force update which doesn't use the cache.
@ -51,6 +52,7 @@ window.API_METHODS = Object.assign(window.API_METHODS || {}, {
} else { } else {
updateIconBadge(this.sender.tab.id, count); updateIconBadge(this.sender.tab.id, count);
} }
}
return true; return true;
}, },