open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add: some fixme

Browse Source
This commit is contained in:
eight 2020-02-01 08:21:41 +08:00
parent 469d6a537a
commit 9b5b39ea3e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
popup/popup.js
View File

@ -106,6 +106,7 @@ function initPopup() {
}); });
$('#popup-options-button').onclick = () => { $('#popup-options-button').onclick = () => {
// FIXME: should we set currentWindow: null?
API.openURL({url: 'manage.html#stylus-options'}); API.openURL({url: 'manage.html#stylus-options'});
window.close(); window.close();
}; };
@ -538,6 +539,7 @@ Object.assign(handleEvent, {
openEditor(event, options) { openEditor(event, options) {
event.preventDefault(); event.preventDefault();
API.openEditor(options); API.openEditor(options);
// FIXME: why do we want to avoid window.close here?
if (!(FIREFOX && prefs.get('openEditInWindow'))) window.close(); if (!(FIREFOX && prefs.get('openEditInWindow'))) window.close();
}, },
@ -583,6 +585,7 @@ Object.assign(handleEvent, {
// edit URLs are ignored by pref - manager URls are passed to openURL() to check if tab exists // edit URLs are ignored by pref - manager URls are passed to openURL() to check if tab exists
// which sends a message to close popup after determining it's not a different FF window // which sends a message to close popup after determining it's not a different FF window
// because closing popup interferes with activating different windows in FF // because closing popup interferes with activating different windows in FF
// FIXME: the popup won't be closed after clicking "Open manager" button
if (this.dataset.href !== 'manage.html') window.close(); if (this.dataset.href !== 'manage.html') window.close();
}); });
}, },
@ -594,6 +597,7 @@ Object.assign(handleEvent, {
this.eventHandled = true; this.eventHandled = true;
this.dataset.href += event.shiftKey || event.button === 2 ? this.dataset.href += event.shiftKey || event.button === 2 ?
'?search=' + encodeURIComponent(`url:${tabURL}`) : ''; '?search=' + encodeURIComponent(`url:${tabURL}`) : '';
// FIXME: should we set currentWindow: null?
handleEvent.openURLandHide.call(this, event); handleEvent.openURLandHide.call(this, event);
} }
}, },