open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Hide popup borer option in newer Chrome versions. Closes #780

Browse Source
This commit is contained in:
Rob Garrison 2019-09-11 21:08:17 -05:00
parent bd50a5604b
commit 84e8478831
4 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
options.html
View File

@ -109,7 +109,7 @@
<span></span>
</span>
</label>
<label class="chromium-only">
<label class="chromium-only chrome-no-popup-border">
<span i18n-text="popupBorders" i18n-title="popupBordersTooltip"></span>
<span class="onoffswitch">
<input type="checkbox" id="popup.borders" class="slider">

3
options/options.css
View File

@ -33,7 +33,8 @@ body {
}
}
.firefox .chromium-only {
.firefox .chromium-only,
.chromium-only.chrome-no-popup-border {
display: none;
}

7
options/options.js
View File

@ -8,6 +8,13 @@ setupRadioButtons();
enforceInputRange($('#popupWidth'));
setTimeout(splitLongTooltips);
if (CHROME >= 3167 && CHROME <= 3704) {
const borderOption = $('.chrome-no-popup-border');
if (borderOption) {
borderOption.classList.remove('chrome-no-popup-border');
}
}
// collapse #advanced block in Chrome pre-66 (classic chrome://extensions UI)
if (!FIREFOX && !OPERA && CHROME < 3343) {
const block = $('#advanced');

7
popup/popup.js
View File

@ -42,7 +42,10 @@ prefs.subscribe(['popup.stylesFirst'], (key, stylesFirst) => {
document.body.insertBefore(installed, before);
});
prefs.subscribe(['popupWidth'], (key, value) => setPopupWidth(value));
prefs.subscribe(['popup.borders'], (key, value) => toggleSideBorders(value));
if (CHROME >= 3167 && CHROME <= 3704) {
prefs.subscribe(['popup.borders'], (key, value) => toggleSideBorders(value));
}
function onRuntimeMessage(msg) {
switch (msg.method) {
@ -68,7 +71,7 @@ function setPopupWidth(width = prefs.get('popupWidth')) {
function toggleSideBorders(state = prefs.get('popup.borders')) {
// runs before <body> is parsed
const style = document.documentElement.style;
if (CHROME >= 3167 && state) {
if (CHROME >= 3167 && CHROME <= 3704 && state) {
style.cssText +=
'border-left: 2px solid white !important;' +
'border-right: 2px solid white !important;';