Merge pull request #143 from tophf/fixes

Fixes

apply.js

@@ -256,6 +256,13 @@ function initObserver() {
 			getDynamicIFrames(document).forEach(addDocumentStylesToIFrame);
 			return;
 		}
+		// move the check out of current execution context
+		// because some same-domain (!) iframes fail to load when their "contentDocument" is accessed (!)
+		// namely gmail's old chat iframe talkgadget.google.com
+		setTimeout(process.bind(null, mutations), 0);
+	});
+
+	function process(mutations) {
 		for (var m = 0, ml = mutations.length; m < ml; m++) {
 			var mutation = mutations[m];
 			if (mutation.type === "childList") {
@@ -267,7 +274,7 @@ function initObserver() {
 				}
 			}
 		}
-	});
+	}
 
 	iframeObserver.start = function() {
 		// will be ignored by browser if already observing

edit.js

@@ -124,7 +124,8 @@ function initCodeMirror() {
 		foldGutter: true,
 		gutters: ["CodeMirror-linenumbers", "CodeMirror-foldgutter", "CodeMirror-lint-markers"],
 		matchBrackets: true,
-		lint: CodeMirror.lint.css,
+		lint: {getAnnotations: CodeMirror.lint.css, delay: prefs.getPref("editor.lintDelay")},
+		lintReportDelay: prefs.getPref("editor.lintReportDelay"),
 		styleActiveLine: true,
 		theme: "default",
 		keyMap: prefs.getPref("editor.keyMap"),
@@ -830,22 +831,34 @@ function updateLintReport(cm, delay) {
 		// by settings its internal delay to 1ms and restoring it back later
 		var lintOpt = editors[0].state.lint.options;
 		setTimeout((function(opt, delay) {
-			opt.delay = delay;
+			opt.delay = delay == 1 ? opt.delay : delay; // options object is shared between editors
 			update(this);
 		}).bind(cm, lintOpt, lintOpt.delay), delay);
 		lintOpt.delay = 1;
 		return;
 	}
+	// user is editing right now: postpone updating the report for the new issues (default: 500ms lint + 4500ms)
+	// or update it as soon as possible (default: 500ms lint + 100ms) in case an existing issue was just fixed
+	var postponeNewIssues = delay == undefined;
 	var state = cm.state.lint;
 	clearTimeout(state.reportTimeout);
-	state.reportTimeout = setTimeout(update.bind(cm), (state.options.delay || 500) + 4500);
+	state.reportTimeout = setTimeout(update.bind(cm), state.options.delay + 100);
+
 	function update() { // this == cm
 		var scope = this ? [this] : editors;
 		var changed = false;
+		var fixedOldIssues = false;
 		scope.forEach(function(cm) {
+			var oldMarkers = cm.state.lint.markedLast || {};
+			var newMarkers = {};
 			var html = cm.state.lint.marked.length == 0 ? "" : "<tbody>" +
 				cm.state.lint.marked.map(function(mark) {
 					var info = mark.__annotation;
+					var pos = info.from.line + "," + info.from.ch;
+					if (oldMarkers[pos] == info.message) {
+						delete oldMarkers[pos];
+					}
+					newMarkers[pos] = info.message;
 					return "<tr class='" + info.severity + "'>" +
 						"<td role='severity' class='CodeMirror-lint-marker-" + info.severity + "'>" +
 							info.severity + "</td>" +
@@ -854,13 +867,22 @@ function updateLintReport(cm, delay) {
 						"<td role='col'>" + (info.from.ch+1) + "</td>" +
 						"<td role='message'>" + info.message.replace(/ at line \d.+$/, "") + "</td></tr>";
 				}).join("") + "</tbody>";
+			cm.state.lint.markedLast = newMarkers;
+			fixedOldIssues |= Object.keys(oldMarkers).length > 0;
 			if (cm.state.lint.html != html) {
 				cm.state.lint.html = html;
 				changed = true;
 			}
 		});
 		if (changed) {
+			clearTimeout(state ? state.renderTimeout : undefined);
+			if (!postponeNewIssues || fixedOldIssues) {
 				renderLintReport(true);
+			} else {
+				state.renderTimeout = setTimeout(function() {
+					renderLintReport(true);
+				}, CodeMirror.defaults.lintReportDelay);
+			}
 		}
 	}
 }
@@ -1053,7 +1075,7 @@ function initWithStyle(style) {
 	function add() {
 		var sectionDiv = addSection(null, queue.shift());
 		maximizeCodeHeight(sectionDiv, !queue.length);
-		updateLintReport(getCodeMirrorForSection(sectionDiv), 500);
+		updateLintReport(getCodeMirrorForSection(sectionDiv), prefs.getPref("editor.lintDelay"));
 	}
 }
 

manage.html

@@ -43,6 +43,9 @@
 				width: 100%; height: 2px;
 				background-color: #fff;
 			}
+			.applies-to {
+				word-break: break-word;
+			}
 			.applies-to, .actions {
 				padding-left: 15px;
 			}

storage.js

@@ -189,6 +189,8 @@ var prefs = {
 		newline_between_rules: false,
 		end_with_newline: false
 	},
+	"editor.lintDelay": 500,        // lint gutter marker update delay, ms
+	"editor.lintReportDelay": 4500, // lint report update delay, ms
 
 	NO_DEFAULT_PREFERENCE: "No default preference for '%s'",
 	UNHANDLED_DATA_TYPE: "Default '%s' is of type '%s' - what should be done with it?",