code cosmetics: fix some eslint complaints
Until https://github.com/eslint/eslint/issues/8594 is sorted out, we're switching to the old indent behavior (indent-legacy).
This commit is contained in:
parent
877d8b19e0
commit
5c1555c781
|
@ -93,7 +93,7 @@ rules:
|
|||
id-blacklist: [0]
|
||||
id-length: [0]
|
||||
id-match: [0]
|
||||
indent: [2, 2, {VariableDeclarator: 0, SwitchCase: 1}]
|
||||
indent-legacy: [2, 2, {VariableDeclarator: 0, SwitchCase: 1}]
|
||||
jsx-quotes: [0]
|
||||
key-spacing: [0]
|
||||
keyword-spacing: [2]
|
||||
|
|
1
apply.js
1
apply.js
|
@ -60,7 +60,6 @@ function applyOnMessage(request, sender, sendResponse) {
|
|||
}
|
||||
|
||||
switch (request.method) {
|
||||
|
||||
case 'styleDeleted':
|
||||
removeStyle(request);
|
||||
break;
|
||||
|
|
|
@ -292,7 +292,6 @@ function updateIcon(tab, styles) {
|
|||
|
||||
function onRuntimeMessage(request, sender, sendResponse) {
|
||||
switch (request.method) {
|
||||
|
||||
case 'getStyles':
|
||||
getStyles(request).then(sendResponse);
|
||||
return KEEP_CHANNEL_OPEN;
|
||||
|
|
|
@ -378,8 +378,7 @@ Object.assign(document.body, {
|
|||
if (event.target === this) {
|
||||
this.ondragend();
|
||||
}
|
||||
}
|
||||
catch (e) {
|
||||
} catch (e) {
|
||||
this.ondragend();
|
||||
}
|
||||
},
|
||||
|
|
4
dom.js
4
dom.js
|
@ -58,7 +58,9 @@ function animateElement(
|
|||
element.removeEventListener('animationend', _);
|
||||
element.classList.remove(
|
||||
className,
|
||||
...removeExtraClasses // In Firefox, `resolve()` might be called one frame later. This is helpful to clean-up on the same frame
|
||||
// In Firefox, `resolve()` might be called one frame later.
|
||||
// This is helpful to clean-up on the same frame
|
||||
...removeExtraClasses
|
||||
);
|
||||
// TODO: investigate why animation restarts if the elements is removed in .then()
|
||||
if (remove) {
|
||||
|
|
2
edit.js
2
edit.js
|
@ -1,4 +1,4 @@
|
|||
/* eslint no-tabs: 0, no-var: 0, indent: [2, tab, {VariableDeclarator: 0, SwitchCase: 1}], quotes: 0 */
|
||||
/* eslint no-tabs: 0, no-var: 0, indent-legacy: [2, tab, {VariableDeclarator: 0, SwitchCase: 1}], quotes: 0 */
|
||||
/* global CodeMirror */
|
||||
"use strict";
|
||||
|
||||
|
|
27
install.js
27
install.js
|
@ -5,13 +5,13 @@ const FIREFOX = /Firefox/.test(navigator.userAgent);
|
|||
const VIVALDI = /Vivaldi/.test(navigator.userAgent);
|
||||
const OPERA = /OPR/.test(navigator.userAgent);
|
||||
|
||||
document.addEventListener("stylishUpdate", onUpdateClicked);
|
||||
document.addEventListener("stylishUpdateChrome", onUpdateClicked);
|
||||
document.addEventListener("stylishUpdateOpera", onUpdateClicked);
|
||||
document.addEventListener('stylishUpdate', onUpdateClicked);
|
||||
document.addEventListener('stylishUpdateChrome', onUpdateClicked);
|
||||
document.addEventListener('stylishUpdateOpera', onUpdateClicked);
|
||||
|
||||
document.addEventListener("stylishInstall", onInstallClicked);
|
||||
document.addEventListener("stylishInstallChrome", onInstallClicked);
|
||||
document.addEventListener("stylishInstallOpera", onInstallClicked);
|
||||
document.addEventListener('stylishInstall', onInstallClicked);
|
||||
document.addEventListener('stylishInstallChrome', onInstallClicked);
|
||||
document.addEventListener('stylishInstallOpera', onInstallClicked);
|
||||
|
||||
chrome.runtime.onMessage.addListener((msg, sender, sendResponse) => {
|
||||
// orphaned content script check
|
||||
|
@ -176,8 +176,7 @@ function checkUpdatability([installedStyle]) {
|
|||
function sendEvent(type, detail = null) {
|
||||
if (FIREFOX) {
|
||||
type = type.replace('Chrome', '');
|
||||
}
|
||||
else if (OPERA || VIVALDI) {
|
||||
} else if (OPERA || VIVALDI) {
|
||||
type = type.replace('Chrome', 'Opera');
|
||||
}
|
||||
detail = {detail};
|
||||
|
@ -336,13 +335,13 @@ function orphanCheck() {
|
|||
}
|
||||
// we're orphaned due to an extension update
|
||||
// we can detach event listeners
|
||||
document.removeEventListener("stylishUpdate", onUpdateClicked);
|
||||
document.removeEventListener("stylishUpdateChrome", onUpdateClicked);
|
||||
document.removeEventListener("stylishUpdateOpera", onUpdateClicked);
|
||||
document.removeEventListener('stylishUpdate', onUpdateClicked);
|
||||
document.removeEventListener('stylishUpdateChrome', onUpdateClicked);
|
||||
document.removeEventListener('stylishUpdateOpera', onUpdateClicked);
|
||||
|
||||
document.removeEventListener("stylishInstall", onInstallClicked);
|
||||
document.removeEventListener("stylishInstallChrome", onInstallClicked);
|
||||
document.removeEventListener("stylishInstallOpera", onInstallClicked);
|
||||
document.removeEventListener('stylishInstall', onInstallClicked);
|
||||
document.removeEventListener('stylishInstallChrome', onInstallClicked);
|
||||
document.removeEventListener('stylishInstallOpera', onInstallClicked);
|
||||
|
||||
// we can't detach chrome.runtime.onMessage because it's no longer connected internally
|
||||
// we can destroy global functions in this context to free up memory
|
||||
|
|
Loading…
Reference in New Issue
Block a user