Make fieldset labels siblings to selects

It's odd that they're parents IMO. Since selects have their own click action, clicking to the right of them registering as a checkbox click seems like an oversight, but I just noticed a hover background that suggests otherwise. I think they're better like this, but NBD if you disagree for whatever reason. I suppose I could fix it with pointer events or something in my personal CSS.
This commit is contained in:
narcolepticinsomniac 2017-11-28 03:27:44 -05:00 committed by GitHub
parent c2d68612ec
commit 51dfee9fef
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -162,33 +162,39 @@
<legend id="filters"> <legend id="filters">
<span i18n-text="manageFilters"></span><span id="filters-stats"></span> <span i18n-text="manageFilters"></span><span id="filters-stats"></span>
</legend> </legend>
<label> <div class="filter-selection">
<input id="manage.onlyEnabled" type="checkbox" <label>
data-filter=".enabled" <input id="manage.onlyEnabled" type="checkbox"
data-filter-hide=".disabled"> data-filter=".enabled"
data-filter-hide=".disabled">
</label>
<select id="manage.onlyEnabled.invert"> <select id="manage.onlyEnabled.invert">
<option i18n-text="manageOnlyEnabled" value="false"></option> <option i18n-text="manageOnlyEnabled" value="false"></option>
<option i18n-text="manageOnlyDisabled" value="true"></option> <option i18n-text="manageOnlyDisabled" value="true"></option>
</select> </select>
</label> </div>
<label> <div class="filter-selection">
<input id="manage.onlyLocal" type="checkbox" <label>
data-filter=":not(.updatable)" <input id="manage.onlyLocal" type="checkbox"
data-filter-hide=".updatable"> data-filter=":not(.updatable)"
data-filter-hide=".updatable">
</label>
<select id="manage.onlyLocal.invert" i18n-title="manageOnlyLocalTooltip"> <select id="manage.onlyLocal.invert" i18n-title="manageOnlyLocalTooltip">
<option i18n-text="manageOnlyLocal" value="false"></option> <option i18n-text="manageOnlyLocal" value="false"></option>
<option i18n-text="manageOnlyExternal" value="true"></option> <option i18n-text="manageOnlyExternal" value="true"></option>
</select> </select>
</label> </div>
<label> <div class="filter-selection">
<input id="manage.onlyUsercss" type="checkbox" <label>
data-filter=".usercss" <input id="manage.onlyUsercss" type="checkbox"
data-filter-hide=":not(.usercss)"> data-filter=".usercss"
data-filter-hide=":not(.usercss)">
</label>
<select id="manage.onlyUsercss.invert"> <select id="manage.onlyUsercss.invert">
<option i18n-text="manageOnlyUsercss" value="false"></option> <option i18n-text="manageOnlyUsercss" value="false"></option>
<option i18n-text="manageOnlyNonUsercss" value="true"></option> <option i18n-text="manageOnlyNonUsercss" value="true"></option>
</select> </select>
</label> </div>
<label id="onlyUpdates" class="hidden"> <label id="onlyUpdates" class="hidden">
<input type="checkbox" <input type="checkbox"
data-filter=".can-update, .update-problem, .update-done" data-filter=".can-update, .update-problem, .update-done"