Fix & cleanup config in popup. Closes #602

This commit is contained in:
Rob Garrison 2018-12-05 07:18:21 -06:00
parent 779a6e4e35
commit 3b5bf36b5c

View File

@ -276,15 +276,20 @@ function createStyleElement({
});
styleName.checkbox = checkbox;
styleName.appendChild(document.createTextNode(' '));
const config = $('.configure', entry);
config.onclick = handleEvent.configure;
if (!style.usercssData && style.updateUrl && style.updateUrl.includes('?') && style.url) {
config.href = style.url;
config.target = '_blank';
config.title = t('configureStyleOnHomepage');
config.dataset.sendMessage = JSON.stringify({method: 'openSettings'});
$('use', config).attributes['xlink:href'].nodeValue = '#svg-icon-config-uso';
} else if (style.usercssData && Object.keys(style.usercssData.vars || {}).length === 0) {
config.classList.add('hidden');
}
$('.delete', entry).onclick = handleEvent.delete;
$('.configure', entry).onclick = handleEvent.configure;
const indicator = template.regexpProblemIndicator.cloneNode(true);
indicator.appendChild(document.createTextNode('!'));
@ -307,15 +312,6 @@ function createStyleElement({
styleName.textContent : '';
});
const config = $('.configure', entry);
if (!style.usercssData && style.updateUrl && style.updateUrl.includes('?') && style.url) {
config.href = style.url;
}
config.style.display =
!style.usercssData && config.href ||
style.usercssData && Object.keys(style.usercssData.vars || {}).length ?
'' : 'none';
entry.classList.toggle('not-applied', style.excluded || style.sloppy);
entry.classList.toggle('regexp-partial', style.sloppy);