open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Popup overflow

Browse Source 
Moving `#hotkey-info` inside of `#installed` still makes the most sense to me. With a few adjustments to the CSS, we can lose the js calc for its height altogether. I also don't see a reason for it to be the entire height of the popup if the popup is already tall enough to accommodate it, so I adjusted that as well. I don't think a wrapper would be a huge deal, but I don't see a need for one anyway.

I suppose there may be scenarios I'm not accounting for, but everything appears to look right and work correctly with these changes. Goes without saying, whenever I modify js it should be scrutinized. In this case I wouldn't be surprised if I left some code made irrelevant by what I removed.
This commit is contained in:
narcolepticinsomniac 2017-12-12 03:19:25 -05:00 committed by GitHub
parent ad692d4f61
commit 3789a6ab49
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
popup.html
View File

@ -176,9 +176,9 @@
</div>
</div>
<aside id="hotkey-info" i18n-title="popupHotkeysTooltip"></aside>
<div id="installed"></div>
<div id="installed">
<aside id="hotkey-info" i18n-title="popupHotkeysTooltip"></aside>
</div>
<div class="actions">
<div id="disable-all-wrapper">