open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix opening own pages from an incognito window popup in Chrome

Browse Source
This commit is contained in:
tophf 2017-08-26 15:57:33 +03:00
parent 8976bd58b8
commit 243da0b0d1
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
js/messaging.js
View File

@ -178,12 +178,15 @@ function openURL({url, currentWindow = true}) {
}
}
getActiveTab().then(tab => {
if (tab && tab.url === 'chrome://newtab/'
// prevent redirecting incognito NTP to a chrome URL as it crashes Chrome
&& (!url.startsWith('chrome') || !tab.incognito)) {
const chromeInIncognito = tab && tab.incognito && url.startsWith('chrome');
if (tab && tab.url === 'chrome://newtab/' && !chromeInIncognito) {
// update current NTP, except for chrome:// or chrome-extension:// in incognito
chrome.tabs.update({url}, resolve);
} else {
chrome.tabs.create(tab && !FIREFOX ? {url, openerTabId: tab.id} : {url}, resolve);
// create a new tab
const openerSupported = !FIREFOX && tab && !chromeInIncognito;
const options = openerSupported ? {url, openerTabId: tab.id} : {url};
chrome.tabs.create(options, resolve);
}
});
});