open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Editor: less obtrusive CSSLint reporting in header, wait ~5s

Browse Source 
* Keep the old timeout after page init ~500ms
* Immediately show the report in onbeforeunload and save
This commit is contained in:
tophf 2015-08-02 18:11:15 +03:00
parent e1b8b48980
commit 1ad92001c0
1 changed files with 58 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

59
edit.js
View File

@ -461,7 +461,11 @@ window.onbeforeunload = function() {
});
}
document.activeElement.blur();
return !isCleanGlobal() ? t('styleChangesNotSaved') : null;
if (isCleanGlobal()) {
return;
}
updateLintReport(null, 0);
return confirm(t('styleChangesNotSaved'));
}
function addAppliesTo(list, name, value) {
@ -763,13 +767,32 @@ function getEditorInSight(nearbyElement) {
}
}
function updateLintReport(cm) {
function updateLintReport(cm, delay) {
if (delay == 0) {
// immediately show pending csslint messages in onbeforeunload and save
update.call(cm);
return;
}
if (delay > 0) {
// give csslint some time to find the issues, e.g. 500 (1/10 of our default 5s)
// by settings its internal delay to 1ms and restoring it back later
var lintOpt = editors[0].state.lint.options;
setTimeout((function(opt, delay) {
opt.delay = delay;
update(this);
}).bind(cm, lintOpt, lintOpt.delay), delay);
lintOpt.delay = 1;
return;
}
var state = cm.state.lint;
clearTimeout(state.reportTimeout);
state.reportTimeout = setTimeout(update.bind(cm), (state.options.delay || 500) + 500);
state.reportTimeout = setTimeout(update.bind(cm), (state.options.delay || 500) + 4500);
function update() { // this == cm
var html = this.state.lint.marked.length == 0 ? "" : "<tbody>" +
this.state.lint.marked.map(function(mark) {
var scope = this ? [this] : editors;
var changed = false;
scope.forEach(function(cm) {
var html = cm.state.lint.marked.length == 0 ? "" : "<tbody>" +
cm.state.lint.marked.map(function(mark) {
var info = mark.__annotation;
return "<tr class='" + info.severity + "'>" +
"<td role='severity' class='CodeMirror-lint-marker-" + info.severity + "'>" +
@ -779,8 +802,12 @@ function updateLintReport(cm) {
"<td role='col'>" + (info.from.ch+1) + "</td>" +
"<td role='message'>" + info.message.replace(/ at line \d.+$/, "") + "</td></tr>";
}).join("") + "</tbody>";
if (this.state.lint.html != html) {
this.state.lint.html = html;
if (cm.state.lint.html != html) {
cm.state.lint.html = html;
changed = true;
}
});
if (changed) {
renderLintReport(true);
}
}
@ -961,17 +988,21 @@ function initWithStyle(style) {
var queueStart = new Date().getTime();
// after 100ms the sections will be added asynchronously
while (new Date().getTime() - queueStart <= 100 && queue.length) {
maximizeCodeHeight(addSection(null, queue.shift()), !queue.length);
add();
}
(function processQueue() {
if (queue.length) {
setTimeout(function processQueue() {
maximizeCodeHeight(addSection(null, queue.shift()), !queue.length);
if (queue.length) {
add();
setTimeout(processQueue, 0);
}
}, 0);
}
})();
initHooks();
function add() {
var sectionDiv = addSection(null, queue.shift());
maximizeCodeHeight(sectionDiv, !queue.length);
updateLintReport(getCodeMirrorForSection(sectionDiv), 500);
}
}
function initHooks() {
@ -1081,6 +1112,8 @@ function validate() {
}
function save() {
updateLintReport(null, 0);
// save the contents of the CodeMirror editors back into the textareas
for (var i=0; i < editors.length; i++) {
editors[i].save();