open.source/stylus
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Popup regression fix: handle disableAll checkbox in active popup

Browse Source 
Apparently the original sender tab is excluded from
chrome.extension.sendMessage broadcast as of Chrome 44.
Even if it's a temporary bug the fixed method is okay.
This commit is contained in:
tophf 2015-05-08 02:23:19 +03:00
parent e2bf12ac6d
commit 0b821463c8
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
popup.js
View File

@ -220,9 +220,11 @@ chrome.extension.onMessage.addListener(function(request, sender, sendResponse) {
case "styleDeleted": case "styleDeleted":
handleDelete(request.id); handleDelete(request.id);
break; break;
case "styleDisableAll": case "prefChanged":
document.getElementById("disableAll").checked = request.disableAll; if (request.prefName == "disableAll") {
handleDisableAll(request.disableAll); document.getElementById("disableAll").checked = request.value;
handleDisableAll(request.value);
}
break; break;
} }
} }
@ -236,4 +238,5 @@ loadPrefs({"disableAll": false});
handleDisableAll(prefs.getPref("disableAll")); handleDisableAll(prefs.getPref("disableAll"));
document.getElementById("disableAll").addEventListener("change", function(event) { document.getElementById("disableAll").addEventListener("change", function(event) {
notifyAllTabs({method: "styleDisableAll", disableAll: event.target.checked}); notifyAllTabs({method: "styleDisableAll", disableAll: event.target.checked});
handleDisableAll(event.target.checked);
}); });