open.source/springy
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add review comments for springyui.js

Browse Source
This commit is contained in:
Andrew Cameron 2011-08-14 11:57:04 -04:00
parent d549ac1d98
commit e04ea5a767
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
springyui.js
View File

@ -39,6 +39,7 @@ jQuery.fn.springy = function(params) {
var ctx = canvas.getContext("2d"); var ctx = canvas.getContext("2d");
var layout = new Layout.ForceDirected(graph, stiffness, repulsion, damping); var layout = new Layout.ForceDirected(graph, stiffness, repulsion, damping);
// This code is duplicated in springy.js.
var requestAnimFrame = var requestAnimFrame =
window.requestAnimationFrame || window.requestAnimationFrame ||
window.webkitRequestAnimationFrame || window.webkitRequestAnimationFrame ||
@ -96,6 +97,8 @@ jQuery.fn.springy = function(params) {
if (selected.node !== null) if (selected.node !== null)
{ {
// Part of the same bug mentioned later. Store the previous mass
// before upscaling it for dragging.
dragged.point.m = 10000.0; dragged.point.m = 10000.0;
} }
@ -117,6 +120,9 @@ jQuery.fn.springy = function(params) {
}); });
jQuery(window).bind('mouseup',function(e){ jQuery(window).bind('mouseup',function(e){
// Bug! Node's mass isn't reset on mouseup. Nodes which have been
// dragged don't repulse very well. Store the initial mass in mousedown
// and then restore it here.
dragged = null; dragged = null;
}); });
@ -137,6 +143,7 @@ jQuery.fn.springy = function(params) {
}; };
Node.prototype.getHeight = function() { Node.prototype.getHeight = function() {
// Magic number with no explanation.
return 20; return 20;
}; };