chore: more cleanup

This commit is contained in:
NunoSempere 2023-03-28 12:00:07 -06:00
parent b2bc83ce80
commit dbc334e870
2 changed files with 8 additions and 7 deletions

View File

@ -49,12 +49,12 @@ You can also see more detailed instructions [here](./user-scripts/ubuntu-20.04/i
- [ ] Double check newtab/next-tab behavior - [ ] Double check newtab/next-tab behavior
- [ ] Find out what each of the css elements refers to. - [ ] Find out what each of the css elements refers to.
- [ ] Use something other than Whatsapp as an example syslink. - [ ] Use something other than Whatsapp as an example syslink.
- [ ] Set `webkit_web_context_set_sandbox_enabled` (<https://webkitgtk.org/reference/webkit2gtk/2.36.8/WebKitWebContext.html#webkit-web-context-set-sandbox-enabled>), as recommended here: <https://blogs.gnome.org/mcatanzaro/2022/11/04/stop-using-qtwebkit/>. - [ ] Set [`webkit_web_context_set_sandbox_enabled`](<https://webkitgtk.org/reference/webkit2gtk/2.36.8/WebKitWebContext.html#webkit-web-context-set-sandbox-enabled>), as recommended [here](<https://blogs.gnome.org/mcatanzaro/2022/11/04/stop-using-qtwebkit/>)
- [ ] Fix bug about distorted audio. Maybe related to <https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1547> - [ ] Fix bug about distorted audio. Maybe related to [this pipewire issue](<https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/1547>)?
Done: Done:
- [x] Document stand_in.c better - [x] Document `stand_in.c` better
- [x] Use a makefile. - [x] Use a makefile.
- [x] Add clean, uninstall to makefile - [x] Add clean, uninstall to makefile
- [x] Mask user agent - [x] Mask user agent
@ -69,7 +69,7 @@ Done:
- [x] Add "open in new window" functionality. - [x] Add "open in new window" functionality.
- Useful for opening links in new tab when clicking on them and selecting that option - Useful for opening links in new tab when clicking on them and selecting that option
- And for actually opening links with the href new_tab option. - And for actually opening links with the href new_tab option.
- Links: <https://docs.gtk.org/gobject/func.signal_connect.html>, <https://webkitgtk.org/reference/webkit2gtk/2.37.90/signal.AutomationSession.create-web-view.html>, <https://webkitgtk.org/reference/webkit2gtk/2.26.0/WebKitWebView.html#WebKitWebView-create> <https://stackoverflow.com/questions/40180757/webkit2gtk-get-new-window-link> - Links: [1](<https://docs.gtk.org/gobject/func.signal_connect.html>), [2](<https://webkitgtk.org/reference/webkit2gtk/2.37.90/signal.AutomationSession.create-web-view.html>), [3](<https://webkitgtk.org/reference/webkit2gtk/2.26.0/WebKitWebView.html#WebKitWebView-create>), [4](<https://stackoverflow.com/questions/40180757/webkit2gtk-get-new-window-link>)
### Known bugs ### Known bugs

7
rose.c
View File

@ -22,9 +22,10 @@ int CUSTOM_USER_AGENT = true;
// - set their variable to true // - set their variable to true
// - in build.sh, uncomment: REQS= #./plugins/*/*.c // - in build.sh, uncomment: REQS= #./plugins/*/*.c
// 2. Remove stand_in code; // 2. Remove stand_in code;
// - Comment out #include "plugins/stand_in/stand_in.h" line, or edit it // - Add an #include "plugins/stand_in/stand_in.h" line, and modify
// together with stand_in.c so as to not include the plugin functions. // stand_in.c so as to include stand-in functions for the excluded plugin
// - In build.sh, comment out REQS=./plugins/stand_in/stand_in.c // - In the make file, include the stand_in.c file and exclude the
// relevant plugin
#define CACHE \ #define CACHE \
"base-cache-directory", CACHE_DIR, "base-data-directory", CACHE_DIR, \ "base-cache-directory", CACHE_DIR, "base-data-directory", CACHE_DIR, \