open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Small fixups

Browse Source
This commit is contained in:
Marshall Polaris 2022-05-04 11:03:29 -07:00
parent e79e0c2d30
commit f0ec02d48b
2 changed files with 27 additions and 35 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
functions/src/scripts/denormalize-avatar-urls.ts
View File

@ -14,10 +14,8 @@ import { DocumentSnapshot, Transaction } from 'firebase-admin/firestore'
initAdmin() initAdmin()
const firestore = admin.firestore() const firestore = admin.firestore()
async function getUsersById( async function getUsersById(transaction: Transaction) {
transaction: Transaction const results = new Map<string, DocumentSnapshot>()
): Promise<Map<string, DocumentSnapshot>> {
const results = new Map()
const users = await transaction.get(firestore.collection('users')) const users = await transaction.get(firestore.collection('users'))
users.forEach((doc) => { users.forEach((doc) => {
results.set(doc.get('id'), doc) results.set(doc.get('id'), doc)
@ -26,15 +24,13 @@ async function getUsersById(
return results return results
} }
async function getContractsByUserId( async function getContractsByUserId(transaction: Transaction) {
transaction: Transaction
): Promise<Map<string, DocumentSnapshot[]>> {
let n = 0 let n = 0
const results = new Map() const results = new Map<string, DocumentSnapshot[]>()
const contracts = await transaction.get(firestore.collection('contracts')) const contracts = await transaction.get(firestore.collection('contracts'))
contracts.forEach((doc) => { contracts.forEach((doc) => {
let creatorId = doc.get('creatorId') const creatorId = doc.get('creatorId')
let creatorContracts = results.get(creatorId) || [] const creatorContracts = results.get(creatorId) || []
creatorContracts.push(doc) creatorContracts.push(doc)
results.set(creatorId, creatorContracts) results.set(creatorId, creatorContracts)
n++ n++
@ -43,15 +39,13 @@ async function getContractsByUserId(
return results return results
} }
async function getCommentsByUserId( async function getCommentsByUserId(transaction: Transaction) {
transaction: Transaction
): Promise<Map<string, DocumentSnapshot[]>> {
let n = 0 let n = 0
let results = new Map() const results = new Map<string, DocumentSnapshot[]>()
let comments = await transaction.get(firestore.collectionGroup('comments')) const comments = await transaction.get(firestore.collectionGroup('comments'))
comments.forEach((doc) => { comments.forEach((doc) => {
let userId = doc.get('userId') const userId = doc.get('userId')
let userComments = results.get(userId) || [] const userComments = results.get(userId) || []
userComments.push(doc) userComments.push(doc)
results.set(userId, userComments) results.set(userId, userComments)
n++ n++
@ -60,15 +54,13 @@ async function getCommentsByUserId(
return results return results
} }
async function getAnswersByUserId( async function getAnswersByUserId(transaction: Transaction) {
transaction: Transaction
): Promise<Map<string, DocumentSnapshot[]>> {
let n = 0 let n = 0
let results = new Map() const results = new Map<string, DocumentSnapshot[]>()
let answers = await transaction.get(firestore.collectionGroup('answers')) const answers = await transaction.get(firestore.collectionGroup('answers'))
answers.forEach((doc) => { answers.forEach((doc) => {
let userId = doc.get('userId') const userId = doc.get('userId')
let userAnswers = results.get(userId) || [] const userAnswers = results.get(userId) || []
userAnswers.push(doc) userAnswers.push(doc)
results.set(userId, userAnswers) results.set(userId, userAnswers)
n++ n++
@ -79,7 +71,7 @@ async function getAnswersByUserId(
if (require.main === module) { if (require.main === module) {
admin.firestore().runTransaction(async (transaction) => { admin.firestore().runTransaction(async (transaction) => {
let [usersById, contractsByUserId, commentsByUserId, answersByUserId] = const [usersById, contractsByUserId, commentsByUserId, answersByUserId] =
await Promise.all([ await Promise.all([
getUsersById(transaction), getUsersById(transaction),
getContractsByUserId(transaction), getContractsByUserId(transaction),
@ -87,13 +79,13 @@ if (require.main === module) {
getAnswersByUserId(transaction), getAnswersByUserId(transaction),
]) ])
let usersContracts = Array.from( const usersContracts = Array.from(
usersById.entries(), usersById.entries(),
([id, doc]): DocumentCorrespondence => { ([id, doc]): DocumentCorrespondence => {
return [doc, contractsByUserId.get(id) || []] return [doc, contractsByUserId.get(id) || []]
} }
) )
let contractDiffs = findDiffs( const contractDiffs = findDiffs(
usersContracts, usersContracts,
'avatarUrl', 'avatarUrl',
'creatorAvatarUrl' 'creatorAvatarUrl'
@ -104,26 +96,26 @@ if (require.main === module) {
applyDiff(transaction, d) applyDiff(transaction, d)
}) })
let usersComments = Array.from( const usersComments = Array.from(
usersById.entries(), usersById.entries(),
([id, doc]): DocumentCorrespondence => { ([id, doc]): DocumentCorrespondence => {
return [doc, commentsByUserId.get(id) || []] return [doc, commentsByUserId.get(id) || []]
} }
) )
let commentDiffs = findDiffs(usersComments, 'avatarUrl', 'userAvatarUrl') const commentDiffs = findDiffs(usersComments, 'avatarUrl', 'userAvatarUrl')
console.log(`Found ${commentDiffs.length} comments with mismatches.`) console.log(`Found ${commentDiffs.length} comments with mismatches.`)
commentDiffs.forEach((d) => { commentDiffs.forEach((d) => {
console.log(describeDiff(d)) console.log(describeDiff(d))
applyDiff(transaction, d) applyDiff(transaction, d)
}) })
let usersAnswers = Array.from( const usersAnswers = Array.from(
usersById.entries(), usersById.entries(),
([id, doc]): DocumentCorrespondence => { ([id, doc]): DocumentCorrespondence => {
return [doc, answersByUserId.get(id) || []] return [doc, answersByUserId.get(id) || []]
} }
) )
let answerDiffs = findDiffs(usersAnswers, 'avatarUrl', 'avatarUrl') const answerDiffs = findDiffs(usersAnswers, 'avatarUrl', 'avatarUrl')
console.log(`Found ${answerDiffs.length} answers with mismatches.`) console.log(`Found ${answerDiffs.length} answers with mismatches.`)
answerDiffs.forEach((d) => { answerDiffs.forEach((d) => {
console.log(describeDiff(d)) console.log(describeDiff(d))

8
functions/src/scripts/denormalize.ts
View File

@ -18,8 +18,8 @@ export function findDiffs(
docs: DocumentCorrespondence[], docs: DocumentCorrespondence[],
srcPath: string, srcPath: string,
destPath: string destPath: string
): DocumentDiff[] { ) {
let diffs = [] const diffs: DocumentDiff[] = []
for (let [srcDoc, destDocs] of docs) { for (let [srcDoc, destDocs] of docs) {
const srcVal = srcDoc.get(srcPath) const srcVal = srcDoc.get(srcPath)
for (let destDoc of destDocs) { for (let destDoc of destDocs) {
@ -35,7 +35,7 @@ export function findDiffs(
return diffs return diffs
} }
export function describeDiff(diff: DocumentDiff): string { export function describeDiff(diff: DocumentDiff) {
function describeDocVal(x: DocumentValue): string { function describeDocVal(x: DocumentValue): string {
return `${x.doc.ref.path}.${x.field}: ${x.val}` return `${x.doc.ref.path}.${x.field}: ${x.val}`
} }
@ -43,6 +43,6 @@ export function describeDiff(diff: DocumentDiff): string {
} }
export function applyDiff(transaction: Transaction, diff: DocumentDiff) { export function applyDiff(transaction: Transaction, diff: DocumentDiff) {
let { src, dest } = diff const { src, dest } = diff
transaction.update(dest.doc.ref, dest.field, src.val) transaction.update(dest.doc.ref, dest.field, src.val)
} }