Fix loans (user without a portfolio throws error)

functions/src/update-loans.ts

@@ -7,6 +7,7 @@ import { Contract } from '../../common/contract'
 import { PortfolioMetrics, User } from '../../common/user'
 import { getLoanUpdates } from '../../common/loans'
 import { createLoanIncomeNotification } from './create-notification'
+import { filterDefined } from 'common/util/array'
 
 const firestore = admin.firestore()
 
@@ -30,16 +31,18 @@ async function updateLoansCore() {
   log(
     `Loaded ${users.length} users, ${contracts.length} contracts, and ${bets.length} bets.`
   )
-  const userPortfolios = await Promise.all(
-    users.map(async (user) => {
-      const portfolio = await getValues<PortfolioMetrics>(
-        firestore
-          .collection(`users/${user.id}/portfolioHistory`)
-          .orderBy('timestamp', 'desc')
-          .limit(1)
-      )
-      return portfolio[0]
-    })
+  const userPortfolios = filterDefined(
+    await Promise.all(
+      users.map(async (user) => {
+        const portfolio = await getValues<PortfolioMetrics>(
+          firestore
+            .collection(`users/${user.id}/portfolioHistory`)
+            .orderBy('timestamp', 'desc')
+            .limit(1)
+        )
+        return portfolio[0]
+      })
+    )
   )
   log(`Loaded ${userPortfolios.length} portfolios`)
   const portfolioByUser = keyBy(userPortfolios, (portfolio) => portfolio.userId)