open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make comment position calculation more robust

Browse Source
This commit is contained in:
Marshall Polaris 2022-09-20 15:39:34 -07:00
parent 60c79141aa
commit cc55a10b19
2 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
common/calculate.ts
View File

@ -257,11 +257,6 @@ export function getTopAnswer(
}
export function getLargestPosition(contract: Contract, userBets: Bet[]) {
let yesFloorShares = 0,
yesShares = 0,
noShares = 0,
noFloorShares = 0
if (userBets.length === 0) {
return null
}
@ -286,12 +281,10 @@ export function getLargestPosition(contract: Contract, userBets: Bet[]) {
}
const [yesBets, noBets] = partition(userBets, (bet) => bet.outcome === 'YES')
yesShares = sumBy(yesBets, (bet) => bet.shares)
noShares = sumBy(noBets, (bet) => bet.shares)
yesFloorShares = Math.floor(yesShares)
noFloorShares = Math.floor(noShares)
const shares = yesFloorShares || noFloorShares
const outcome = yesFloorShares > noFloorShares ? 'YES' : 'NO'
return { shares, outcome }
const yesShares = sumBy(yesBets, (bet) => bet.shares)
const noShares = sumBy(noBets, (bet) => bet.shares)
return {
shares: Math.abs(yesShares - noShares),
outcome: yesShares > noShares ? 'YES' : 'NO',
}
}

2
web/components/feed/feed-comments.tsx
View File

@ -134,7 +134,7 @@ export function FeedComment(props: {
commenterPositionProb != null &&
commenterPositionOutcome != null &&
commenterPositionShares != null &&
commenterPositionShares > 0 &&
Math.floor(commenterPositionShares) > 0 &&
contract.outcomeType !== 'NUMERIC' && (
<>
{'is '}