Remove unnecessary avatar wrapper div
This commit is contained in:
parent
02e7efe30c
commit
ca6c14de50
|
@ -10,8 +10,7 @@ export function Avatar(props: {
|
||||||
className?: string
|
className?: string
|
||||||
containerClassName?: string
|
containerClassName?: string
|
||||||
}) {
|
}) {
|
||||||
const { username, avatarUrl, noLink, size, className, containerClassName } =
|
const { username, avatarUrl, noLink, size, className } = props
|
||||||
props
|
|
||||||
const s = size == 'xs' ? 6 : size === 'sm' ? 8 : size || 10
|
const s = size == 'xs' ? 6 : size === 'sm' ? 8 : size || 10
|
||||||
|
|
||||||
const onClick =
|
const onClick =
|
||||||
|
@ -21,32 +20,28 @@ export function Avatar(props: {
|
||||||
e.stopPropagation()
|
e.stopPropagation()
|
||||||
Router.push(`/${username}`)
|
Router.push(`/${username}`)
|
||||||
}
|
}
|
||||||
return (
|
|
||||||
<div
|
// there can be no avatar URL or username in the feed, we show a "submit comment"
|
||||||
|
// item with a fake grey user circle guy even if you aren't signed in
|
||||||
|
return avatarUrl ? (
|
||||||
|
<img
|
||||||
className={clsx(
|
className={clsx(
|
||||||
`flex-shrink-0 rounded-full bg-white w-${s} h-${s}`,
|
'flex-shrink-0 rounded-full rounded-full bg-white object-cover',
|
||||||
containerClassName
|
`w-${s} h-${s}`,
|
||||||
|
!noLink && 'cursor-pointer',
|
||||||
|
className
|
||||||
)}
|
)}
|
||||||
>
|
src={avatarUrl}
|
||||||
{avatarUrl ? (
|
onClick={onClick}
|
||||||
<img
|
alt={username}
|
||||||
className={clsx(
|
/>
|
||||||
'rounded-full object-cover',
|
) : (
|
||||||
`w-${s} h-${s}`,
|
<UserCircleIcon
|
||||||
!noLink && 'cursor-pointer',
|
className={clsx(
|
||||||
className
|
`flex-shrink-0 rounded-full bg-white w-${s} h-${s} text-gray-500`,
|
||||||
)}
|
className
|
||||||
src={avatarUrl}
|
|
||||||
onClick={onClick}
|
|
||||||
alt={username}
|
|
||||||
/>
|
|
||||||
) : (
|
|
||||||
// TODO: After 2022-03-01, can just assume that all contracts have an avatarUrl
|
|
||||||
<UserCircleIcon
|
|
||||||
className={`w-${s} h-${s} text-gray-500`}
|
|
||||||
aria-hidden="true"
|
|
||||||
/>
|
|
||||||
)}
|
)}
|
||||||
</div>
|
aria-hidden="true"
|
||||||
|
/>
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
|
@ -60,7 +60,7 @@ export function BottomNavBar() {
|
||||||
) : user ? (
|
) : user ? (
|
||||||
<>
|
<>
|
||||||
<Avatar
|
<Avatar
|
||||||
containerClassName="mx-auto my-1"
|
className="mx-auto my-1"
|
||||||
size="xs"
|
size="xs"
|
||||||
username={user.username}
|
username={user.username}
|
||||||
avatarUrl={user.avatarUrl}
|
avatarUrl={user.avatarUrl}
|
||||||
|
|
Loading…
Reference in New Issue
Block a user