Fix google lighthouse issues (#1013)

This commit is contained in:
Sinclair Chen 2022-10-06 15:19:37 -07:00 committed by GitHub
parent a63405ca7c
commit adb809f973
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 5 additions and 7 deletions

View File

@ -22,6 +22,7 @@ export function ManifoldLogo(props: {
src={darkBackground ? '/logo-white.svg' : '/logo.svg'}
width={45}
height={45}
alt=""
/>
{!hideText &&

View File

@ -11,13 +11,13 @@ function SidebarButton(props: {
}) {
const { text, children } = props
return (
<a className="group flex items-center rounded-md px-3 py-2 text-sm font-medium text-gray-600 hover:cursor-pointer hover:bg-gray-100">
<button className="group flex w-full items-center rounded-md px-3 py-2 text-sm font-medium text-gray-600 hover:cursor-pointer hover:bg-gray-100">
<props.icon
className="-ml-1 mr-3 h-6 w-6 flex-shrink-0 text-gray-400 group-hover:text-gray-500"
aria-hidden="true"
/>
<span className="truncate">{text}</span>
{children}
</a>
</button>
)
}

View File

@ -74,10 +74,7 @@ function MyApp({ Component, pageProps }: AppProps<ManifoldPageProps>) {
content="https://manifold.markets/logo-bg-white.png"
key="image2"
/>
<meta
name="viewport"
content="width=device-width, initial-scale=1, maximum-scale=1"
/>
<meta name="viewport" content="width=device-width, initial-scale=1" />
</Head>
<AuthProvider serverUser={pageProps.auth}>
<QueryClientProvider client={queryClient}>

View File

@ -3,7 +3,7 @@ import { ENV_CONFIG } from 'common/envs/constants'
export default function Document() {
return (
<Html data-theme="mantic" className="min-h-screen">
<Html lang="en" data-theme="mantic" className="min-h-screen">
<Head>
<link rel="icon" href={ENV_CONFIG.faviconPath} />
<link