open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ensure bet amounts are positive

Browse Source
This commit is contained in:
mantikoros 2022-01-08 11:51:31 -06:00
parent 6398f93ffe
commit abb5d53431
4 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
functions/src/create-contract.ts
View File

@ -32,7 +32,10 @@ export const createContract = functions
if (!question || !initialProb) if (!question || !initialProb)
return { status: 'error', message: 'Missing contract attributes' } return { status: 'error', message: 'Missing contract attributes' }
if (ante !== undefined && (ante < 0 || ante > creator.balance)) if (
ante !== undefined &&
(ante < 0 || ante > creator.balance || isNaN(ante) || !isFinite(ante))
)
return { status: 'error', message: 'Invalid ante' } return { status: 'error', message: 'Invalid ante' }
console.log( console.log(

3
functions/src/place-bet.ts
View File

@ -19,6 +19,9 @@ export const placeBet = functions.runWith({ minInstances: 1 }).https.onCall(
const { amount, outcome, contractId } = data const { amount, outcome, contractId } = data
if (amount <= 0 || isNaN(amount) || !isFinite(amount))
return { status: 'error', message: 'Invalid amount' }
if (outcome !== 'YES' && outcome !== 'NO') if (outcome !== 'YES' && outcome !== 'NO')
return { status: 'error', message: 'Invalid outcome' } return { status: 'error', message: 'Invalid outcome' }

2
web/components/bet-panel.tsx
View File

@ -52,7 +52,7 @@ export function BetPanel(props: { contract: Contract; className?: string }) {
function onBetChange(str: string) { function onBetChange(str: string) {
setWasSubmitted(false) setWasSubmitted(false)
const amount = parseInt(str) const amount = parseInt(str.replace(/[^\d]/, ''))
if (str && isNaN(amount)) return if (str && isNaN(amount)) return

2
web/pages/create.tsx
View File

@ -76,7 +76,7 @@ export default function NewContract() {
} }
function onAnteChange(str: string) { function onAnteChange(str: string) {
const amount = parseInt(str) const amount = parseInt(str.replace(/[^\d]/, ''))
if (str && isNaN(amount)) return if (str && isNaN(amount)) return