open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

If a limit bet doesn't match any orders, don't update the contract, don't redeem shares. Perf win!

Browse Source
This commit is contained in:
James Grugett 2022-07-14 18:01:35 -05:00
parent 6e1aa4b0f4
commit a9018d77c7
1 changed files with 27 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
functions/src/place-bet.ts
View File

@ -128,8 +128,10 @@ export const placebet = newEndpoint({}, async (req, auth) => {
updateMakers(makers, betDoc.id, contractDoc, trans) updateMakers(makers, betDoc.id, contractDoc, trans)
} }
if (newBet.amount !== 0) {
trans.update(userDoc, { balance: FieldValue.increment(-newBet.amount) }) trans.update(userDoc, { balance: FieldValue.increment(-newBet.amount) })
log('Updated user balance.') log('Updated user balance.')
trans.update( trans.update(
contractDoc, contractDoc,
removeUndefinedProps({ removeUndefinedProps({
@ -143,19 +145,21 @@ export const placebet = newEndpoint({}, async (req, auth) => {
}) })
) )
log('Updated contract properties.') log('Updated contract properties.')
}
return { betId: betDoc.id, makers } return { betId: betDoc.id, makers, newBet }
}) })
log('Main transaction finished.') log('Main transaction finished.')
await redeemShares(auth.uid, contractId)
if (result.newBet.amount !== 0) {
const userIds = [ const userIds = [
auth.uid, auth.uid,
...(result.makers ?? []).map((maker) => maker.bet.userId), ...(result.makers ?? []).map((maker) => maker.bet.userId),
] ]
await Promise.all(userIds.map((userId) => redeemShares(userId, contractId))) await Promise.all(userIds.map((userId) => redeemShares(userId, contractId)))
log('Share redemption transaction finished.') log('Share redemption transaction finished.')
}
return { betId: result.betId } return { betId: result.betId }
}) })