Publicly display bets without infinite looping

React why

web/components/bets-list.tsx

@@ -54,9 +54,14 @@ import { SellSharesModal } from './sell-modal'
 type BetSort = 'newest' | 'profit' | 'closeTime' | 'value'
 type BetFilter = 'open' | 'sold' | 'closed' | 'resolved' | 'all'
 
-export function BetsList(props: { user: User }) {
-  const { user } = props
-  const bets = useUserBets(user.id, { includeRedemptions: true })
+export function BetsList(props: { user: User; hideBetsBefore?: number }) {
+  const { user, hideBetsBefore } = props
+  const allBets = useUserBets(user.id, { includeRedemptions: true })
+  // Hide bets before 06-01-2022 if this isn't your own profile
+  // NOTE: This means public profits also begin on 06-01-2022 as well.
+  const bets = (allBets ?? []).filter(
+    (bet) => bet.createdTime >= (hideBetsBefore ?? 0)
+  )
   const [contracts, setContracts] = useState<Contract[] | undefined>()
 
   const [sort, setSort] = useState<BetSort>('newest')
@@ -77,7 +82,7 @@ export function BetsList(props: { user: User }) {
         disposed = true
       }
     }
-  }, [bets])
+  }, [allBets])
 
   const getTime = useTimeSinceFirstRender()
   useEffect(() => {

web/components/user-page.tsx

@@ -44,6 +44,7 @@ export function UserLink(props: {
 }
 
 export const TAB_IDS = ['markets', 'comments', 'bets']
+const JUNE_1_2022 = new Date('2022-06-01T00:00:00.000Z').valueOf()
 
 export function UserPage(props: {
   user: User
@@ -229,14 +230,27 @@ export function UserPage(props: {
                 title: 'Bets',
                 content: (
                   <div>
-                    <AlertBox
-                      title="Bets are becoming publicly visible on 2022-06-01"
-                      text="Bettor identities have always been traceable through the Manifold API.
-                      However, our interface implied that they were private.
-                      As we develop new features such as leaderboards and bet history, it won't be technically feasible to keep this info private.
-                      For more context, or if you'd like to wipe your bet history, see: https://manifold.markets/Austin/will-all-bets-on-manifold-be-public"
+                    {isCurrentUser && (
+                      <AlertBox
+                        title="Bets after 2022-06-01 are publicly visible by default."
+                        text="Note that all historical bets are also publicly accessible through the API.
+                      See: https://manifold.markets/Austin/will-all-bets-on-manifold-be-public"
+                      />
+                    )}
+                    <BetsList
+                      user={user}
+                      hideBetsBefore={isCurrentUser ? 0 : JUNE_1_2022}
                     />
-                    {isCurrentUser && <BetsList user={user} />}
+                    {!isCurrentUser && (
+                      <>
+                        <Spacer h={4} />
+                        <AlertBox
+                          title="Bets before 2022-06-01 are hidden by default."
+                          text="Note that all historical bets are also publicly accessible through the API.
+                        See: https://manifold.markets/Austin/will-all-bets-on-manifold-be-public"
+                        />
+                      </>
+                    )}
                   </div>
                 ),
                 tabIcon: (