open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix crash when there aren't any bets

Browse Source
This commit is contained in:
Austin Chen 2022-03-21 15:19:42 -07:00
parent a9cdeb46a2
commit a3067527ee
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/hooks/use-users.ts
View File

@ -16,11 +16,13 @@ export const useUsers = () => {
return users return users
} }
export const useUserById = (userId: string) => { export const useUserById = (userId?: string) => {
const [user, setUser] = useState<User | undefined>(undefined) const [user, setUser] = useState<User | undefined>(undefined)
useEffect(() => { useEffect(() => {
if (userId) {
getUser(userId).then(setUser) getUser(userId).then(setUser)
}
}, [userId]) }, [userId])
return user return user

2
web/pages/[username]/[contractSlug].tsx
View File

@ -280,7 +280,7 @@ function ContractTopTrades(props: {
// Now find the betId with the highest profit // Now find the betId with the highest profit
const topBetId = _.sortBy(bets, (b) => -profitById[b.id])[0]?.id const topBetId = _.sortBy(bets, (b) => -profitById[b.id])[0]?.id
const topBettor = useUserById(betsById[topBetId].userId) const topBettor = useUserById(betsById[topBetId]?.userId)
// And also the commentId of the comment with the highest profit // And also the commentId of the comment with the highest profit
const topCommentId = _.sortBy(comments, (c) => -profitById[c.betId])[0]?.id const topCommentId = _.sortBy(comments, (c) => -profitById[c.betId])[0]?.id