deduct liquidity from profits

common/add-liquidity.ts

@@ -29,7 +29,5 @@ export const getNewLiquidityProvision = (
 
   const newTotalLiquidity = (totalLiquidity ?? 0) + amount
 
-  const newBalance = user.balance - amount
+  return { newLiquidityProvision, newPool, newP, newTotalLiquidity }
-
-  return { newLiquidityProvision, newPool, newP, newBalance, newTotalLiquidity }
 }

functions/src/add-liquidity.ts

@@ -54,18 +54,13 @@ export const addLiquidity = functions.runWith({ minInstances: 1 }).https.onCall(
           .collection(`contracts/${contractId}/liquidity`)
           .doc()
 
-        const {
+        const { newLiquidityProvision, newPool, newP, newTotalLiquidity } =
-          newLiquidityProvision,
+          getNewLiquidityProvision(
-          newPool,
+            user,
-          newP,
+            amount,
-          newBalance,
+            contract,
-          newTotalLiquidity,
+            newLiquidityProvisionDoc.id
-        } = getNewLiquidityProvision(
+          )
-          user,
-          amount,
-          contract,
-          newLiquidityProvisionDoc.id
-        )
 
         if (newP !== undefined && !isFinite(newP)) {
           return {
@@ -83,11 +78,17 @@ export const addLiquidity = functions.runWith({ minInstances: 1 }).https.onCall(
           })
         )
 
+        const newBalance = user.balance - amount
+        const newTotalDeposits = user.totalDeposits - amount
+
         if (!isFinite(newBalance)) {
           throw new Error('Invalid user balance for ' + user.username)
         }
 
-        transaction.update(userDoc, { balance: newBalance })
+        transaction.update(userDoc, {
+          balance: newBalance,
+          totalDeposits: newTotalDeposits,
+        })
 
         transaction.create(newLiquidityProvisionDoc, newLiquidityProvision)