Working betting with ante'd NONE answer

This commit is contained in:
James Grugett 2022-02-14 18:29:34 -06:00
parent 58afde2772
commit 75aa946bd0
7 changed files with 148 additions and 108 deletions

View File

@ -1,3 +1,5 @@
import { User } from './user'
export type Answer = { export type Answer = {
id: string id: string
contractId: string contractId: string
@ -10,3 +12,18 @@ export type Answer = {
text: string text: string
} }
export const getNoneAnswer = (contractId: string, creator: User) => {
const { username, name, avatarUrl } = creator
return {
id: 'NONE',
contractId,
createdTime: Date.now(),
userId: creator.id,
username,
name,
avatarUrl,
text: 'None',
}
}

View File

@ -67,7 +67,9 @@ export function getFreeAnswerAnte(
contract: Contract<'MULTI'>, contract: Contract<'MULTI'>,
anteBetId: string anteBetId: string
) { ) {
const ante = contract.totalBets.YES + contract.totalBets.NO const { totalBets, totalShares } = contract
const amount = totalBets.NONE
const shares = totalShares.NONE
const { createdTime } = contract const { createdTime } = contract
@ -75,11 +77,11 @@ export function getFreeAnswerAnte(
id: anteBetId, id: anteBetId,
userId: creator.id, userId: creator.id,
contractId: contract.id, contractId: contract.id,
amount: ante, amount,
shares: 0, shares,
outcome: 'NONE', outcome: 'NONE',
probBefore: 0, probBefore: 100,
probAfter: 0, probAfter: 100,
createdTime, createdTime,
isAnte: true, isAnte: true,
} }

View File

@ -1,4 +1,4 @@
import _ from 'lodash' import * as _ from 'lodash'
import { Bet } from './bet' import { Bet } from './bet'
import { Contract } from './contract' import { Contract } from './contract'
import { FEES } from './fees' import { FEES } from './fees'

View File

@ -24,7 +24,7 @@ export function getNewContract(
const propsByOutcomeType = const propsByOutcomeType =
outcomeType === 'BINARY' outcomeType === 'BINARY'
? getBinaryProps(initialProb, ante) ? getBinaryProps(initialProb, ante)
: getFreeAnswerProps() : getFreeAnswerProps(ante)
const contract: Contract<'BINARY' | 'MULTI'> = removeUndefinedProps({ const contract: Contract<'BINARY' | 'MULTI'> = removeUndefinedProps({
id, id,
@ -68,11 +68,11 @@ const getBinaryProps = (initialProb: number, ante: number) => {
} }
} }
const getFreeAnswerProps = () => { const getFreeAnswerProps = (ante: number) => {
return { return {
pool: {}, pool: { NONE: ante },
totalShares: {}, totalShares: { NONE: ante },
totalBets: {}, totalBets: { NONE: ante },
phantomShares: undefined, phantomShares: undefined,
outcomes: 'FREE_ANSWER' as const, outcomes: 'FREE_ANSWER' as const,
} }

View File

@ -11,6 +11,7 @@ import {
getFreeAnswerAnte, getFreeAnswerAnte,
MINIMUM_ANTE, MINIMUM_ANTE,
} from '../../common/antes' } from '../../common/antes'
import { getNoneAnswer } from '../../common/answer'
export const createContract = functions export const createContract = functions
.runWith({ minInstances: 1 }) .runWith({ minInstances: 1 })
@ -106,16 +107,21 @@ export const createContract = functions
await yesBetDoc.set(yesBet) await yesBetDoc.set(yesBet)
await noBetDoc.set(noBet) await noBetDoc.set(noBet)
} else if (outcomeType === 'MULTI') { } else if (outcomeType === 'MULTI') {
const noneAnswerDoc = firestore.doc(
`contracts/${contract.id}/answers/NONE`
)
const noneAnswer = getNoneAnswer(contract.id, creator)
await noneAnswerDoc.set(noneAnswer)
const anteBetDoc = firestore const anteBetDoc = firestore
.collection(`contracts/${contract.id}/bets`) .collection(`contracts/${contract.id}/bets`)
.doc() .doc()
getFreeAnswerAnte( const anteBet = getFreeAnswerAnte(
creator, creator,
contract as Contract<'MULTI'>, contract as Contract<'MULTI'>,
anteBetDoc.id anteBetDoc.id
) )
// Disable until we figure out how this should work. await anteBetDoc.set(anteBet)
// await anteBetDoc.set(anteBetDoc)
} }
} }

View File

@ -1,6 +1,7 @@
import clsx from 'clsx' import clsx from 'clsx'
import { useEffect, useRef, useState } from 'react' import { useEffect, useRef, useState } from 'react'
import Textarea from 'react-expanding-textarea' import Textarea from 'react-expanding-textarea'
import { XIcon } from '@heroicons/react/solid'
import { Answer } from '../../common/answer' import { Answer } from '../../common/answer'
import { Contract } from '../../common/contract' import { Contract } from '../../common/contract'
@ -25,8 +26,10 @@ import {
getProbabilityAfterBet, getProbabilityAfterBet,
getOutcomeProbability, getOutcomeProbability,
calculateShares, calculateShares,
calculatePayoutAfterCorrectBet,
} from '../../common/calculate' } from '../../common/calculate'
import { firebaseLogin } from '../lib/firebase/users' import { firebaseLogin } from '../lib/firebase/users'
import { Bet } from '../../common/bet'
export function AnswersPanel(props: { export function AnswersPanel(props: {
contract: Contract<'MULTI'> contract: Contract<'MULTI'>
@ -49,12 +52,14 @@ function AnswerItem(props: { answer: Answer; contract: Contract<'MULTI'> }) {
const { username, avatarUrl, name, createdTime } = answer const { username, avatarUrl, name, createdTime } = answer
const createdDate = dayjs(createdTime).format('MMM D') const createdDate = dayjs(createdTime).format('MMM D')
const prob = getOutcomeProbability(contract.totalShares, answer.id)
const probPercent = formatPercent(prob)
const [isBetting, setIsBetting] = useState(false) const [isBetting, setIsBetting] = useState(false)
return ( return (
<Col>
<Col className="p-2 sm:flex-row"> <Col className="p-2 sm:flex-row">
<Row className="flex-1">
<Col className="gap-2 flex-1"> <Col className="gap-2 flex-1">
<div>{answer.text}</div> <div>{answer.text}</div>
@ -76,15 +81,26 @@ function AnswerItem(props: { answer: Answer; contract: Contract<'MULTI'> }) {
</Row> </Row>
</Col> </Col>
{!isBetting && (
<Col className="sm:flex-row items-center gap-4">
<div className="text-2xl text-green-500">{probPercent}</div>
<BuyButton <BuyButton
className="justify-end self-end flex-initial" className="justify-end self-end flex-initial btn-md !px-4 sm:!px-8"
onClick={() => { onClick={() => {
setIsBetting(true) setIsBetting(true)
}} }}
/> />
</Col> </Col>
)}
</Row>
{isBetting && <AnswerBetPanel answer={answer} contract={contract} />} {isBetting && (
<AnswerBetPanel
answer={answer}
contract={contract}
closePanel={() => setIsBetting(false)}
/>
)}
</Col> </Col>
) )
} }
@ -92,8 +108,9 @@ function AnswerItem(props: { answer: Answer; contract: Contract<'MULTI'> }) {
function AnswerBetPanel(props: { function AnswerBetPanel(props: {
answer: Answer answer: Answer
contract: Contract<'MULTI'> contract: Contract<'MULTI'>
closePanel: () => void
}) { }) {
const { answer, contract } = props const { answer, contract, closePanel } = props
const { id: answerId } = answer const { id: answerId } = answer
const user = useUser() const user = useUser()
@ -101,18 +118,12 @@ function AnswerBetPanel(props: {
const [error, setError] = useState<string | undefined>() const [error, setError] = useState<string | undefined>()
const [isSubmitting, setIsSubmitting] = useState(false) const [isSubmitting, setIsSubmitting] = useState(false)
const [wasSubmitted, setWasSubmitted] = useState(false)
const inputRef = useRef<HTMLElement>(null) const inputRef = useRef<HTMLElement>(null)
useEffect(() => { useEffect(() => {
inputRef.current && inputRef.current.focus() inputRef.current && inputRef.current.focus()
}, []) }, [])
function onBetChange(newAmount: number | undefined) {
setWasSubmitted(false)
setBetAmount(newAmount)
}
async function submitBet() { async function submitBet() {
if (!user || !betAmount) return if (!user || !betAmount) return
@ -133,9 +144,7 @@ function AnswerBetPanel(props: {
console.log('placed bet. Result:', result) console.log('placed bet. Result:', result)
if (result?.status === 'success') { if (result?.status === 'success') {
setIsSubmitting(false) closePanel()
setWasSubmitted(true)
setBetAmount(undefined)
} else { } else {
setError(result?.error || 'Error placing bet') setError(result?.error || 'Error placing bet')
setIsSubmitting(false) setIsSubmitting(false)
@ -155,25 +164,33 @@ function AnswerBetPanel(props: {
const shares = calculateShares(contract.totalShares, betAmount ?? 0, answerId) const shares = calculateShares(contract.totalShares, betAmount ?? 0, answerId)
const currentPayout = betAmount const currentPayout = betAmount
? 0 ? calculatePayoutAfterCorrectBet(
: // calculatePayoutAfterCorrectBet(contract, { contract as any as Contract,
// outcome: answerId, {
// amount: betAmount, outcome: answerId,
// shares, amount: betAmount,
// } as Bet) shares,
0 } as Bet
)
: 0
const currentReturn = betAmount ? (currentPayout - betAmount) / betAmount : 0 const currentReturn = betAmount ? (currentPayout - betAmount) / betAmount : 0
const currentReturnPercent = (currentReturn * 100).toFixed() + '%' const currentReturnPercent = (currentReturn * 100).toFixed() + '%'
return ( return (
<Col className="items-center"> <Col className="items-start">
<Col className="p-2 items-start"> <Row className="self-stretch items-center justify-between">
<div className="text-xl">Buy this answer</div>
<button className="btn-ghost btn-circle" onClick={closePanel}>
<XIcon className="w-8 h-8 text-gray-500 mx-auto" aria-hidden="true" />
</button>
</Row>
<div className="my-3 text-left text-sm text-gray-500">Amount </div> <div className="my-3 text-left text-sm text-gray-500">Amount </div>
<AmountInput <AmountInput
inputClassName="w-full" inputClassName="w-full"
amount={betAmount} amount={betAmount}
onChange={onBetChange} onChange={setBetAmount}
error={error} error={error}
setError={setError} setError={setError}
disabled={isSubmitting} disabled={isSubmitting}
@ -182,9 +199,7 @@ function AnswerBetPanel(props: {
<Spacer h={4} /> <Spacer h={4} />
<div className="mt-2 mb-1 text-sm text-gray-500"> <div className="mt-2 mb-1 text-sm text-gray-500">Implied probability</div>
Implied probability
</div>
<Row> <Row>
<div>{formatPercent(initialProb)}</div> <div>{formatPercent(initialProb)}</div>
<div className="mx-2"></div> <div className="mx-2"></div>
@ -229,9 +244,6 @@ function AnswerBetPanel(props: {
Sign in to trade! Sign in to trade!
</button> </button>
)} )}
{wasSubmitted && <div className="mt-4">Trade submitted!</div>}
</Col>
</Col> </Col>
) )
} }
@ -267,7 +279,7 @@ function CreateAnswerInput(props: { contract: Contract<'MULTI'> }) {
} }
return ( return (
<Col className="gap-4 mt-2"> <Col className="gap-4 mt-2 px-2">
<Col className="sm:flex-row gap-8"> <Col className="sm:flex-row gap-8">
<Col className="flex-1 gap-2"> <Col className="flex-1 gap-2">
<div className="text-gray-500 text-sm mb-1">Add your answer</div> <div className="text-gray-500 text-sm mb-1">Add your answer</div>

View File

@ -121,10 +121,13 @@ export default function ContractPage(props: {
folds={folds} folds={folds}
> >
{contract.outcomes === 'FREE_ANSWER' && ( {contract.outcomes === 'FREE_ANSWER' && (
<>
<Spacer h={4} />
<AnswersPanel <AnswersPanel
contract={contract as any} contract={contract as any}
answers={props.answers} answers={props.answers}
/> />
</>
)} )}
</ContractOverview> </ContractOverview>