open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up comments

Browse Source
This commit is contained in:
Ian Philips 2022-09-09 10:28:40 -06:00
parent 7308e4f358
commit 4c4fe665ae
3 changed files with 18 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
common/notification.ts
View File

@ -90,7 +90,7 @@ export type notification_reason_types =
| 'your_contract_closed' | 'your_contract_closed'
| 'subsidized_your_market' | 'subsidized_your_market'
// Adding a new key:value here is optional, you can also just use a key of exhaustive_notification_subscribe_types // Adding a new key:value here is optional, you can also just use a key of notification_subscription_types
export const notificationReasonToSubscriptionType: Partial< export const notificationReasonToSubscriptionType: Partial<
Record<notification_reason_types, keyof notification_subscription_types> Record<notification_reason_types, keyof notification_subscription_types>
> = { > = {

34
common/user.ts
View File

@ -73,14 +73,14 @@ export type notification_destination_types = 'email' | 'browser'
export type notification_subscription_types = { export type notification_subscription_types = {
// Watched Markets // Watched Markets
all_comments_on_watched_markets: notification_destination_types[] // Email currently - seems bad all_comments_on_watched_markets: notification_destination_types[]
all_answers_on_watched_markets: notification_destination_types[] // Email currently - seems bad all_answers_on_watched_markets: notification_destination_types[]
// Comments // Comments
tipped_comments_on_watched_markets: notification_destination_types[] // Email tipped_comments_on_watched_markets: notification_destination_types[]
comments_by_followed_users_on_watched_markets: notification_destination_types[] comments_by_followed_users_on_watched_markets: notification_destination_types[]
all_replies_to_my_comments_on_watched_markets: notification_destination_types[] // Email all_replies_to_my_comments_on_watched_markets: notification_destination_types[]
all_replies_to_my_answers_on_watched_markets: notification_destination_types[] // Email all_replies_to_my_answers_on_watched_markets: notification_destination_types[]
all_comments_on_contracts_with_shares_in_on_watched_markets: notification_destination_types[] all_comments_on_contracts_with_shares_in_on_watched_markets: notification_destination_types[]
// Answers // Answers
@ -89,17 +89,17 @@ export type notification_subscription_types = {
all_answers_on_contracts_with_shares_in_on_watched_markets: notification_destination_types[] all_answers_on_contracts_with_shares_in_on_watched_markets: notification_destination_types[]
// On users' markets // On users' markets
your_contract_closed: notification_destination_types[] // Email, Recommended your_contract_closed: notification_destination_types[]
all_comments_on_my_markets: notification_destination_types[] // Email all_comments_on_my_markets: notification_destination_types[]
all_answers_on_my_markets: notification_destination_types[] // Email all_answers_on_my_markets: notification_destination_types[]
subsidized_your_market: notification_destination_types[] // Email subsidized_your_market: notification_destination_types[]
// Market updates // Market updates
resolutions_on_watched_markets: notification_destination_types[] // Email resolutions_on_watched_markets: notification_destination_types[]
resolutions_on_watched_markets_with_shares_in: notification_destination_types[] // Email resolutions_on_watched_markets_with_shares_in: notification_destination_types[]
market_updates_on_watched_markets: notification_destination_types[] market_updates_on_watched_markets: notification_destination_types[]
market_updates_on_watched_markets_with_shares_in: notification_destination_types[] market_updates_on_watched_markets_with_shares_in: notification_destination_types[]
probability_updates_on_watched_markets: notification_destination_types[] // Email - would want persistent changes only though probability_updates_on_watched_markets: notification_destination_types[]
// Balance Changes // Balance Changes
loan_income: notification_destination_types[] loan_income: notification_destination_types[]
@ -111,11 +111,11 @@ export type notification_subscription_types = {
limit_order_fills: notification_destination_types[] limit_order_fills: notification_destination_types[]
// General // General
tagged_user: notification_destination_types[] // Email tagged_user: notification_destination_types[]
on_new_follow: notification_destination_types[] // Email on_new_follow: notification_destination_types[]
contract_from_followed_user: notification_destination_types[] // Email contract_from_followed_user: notification_destination_types[]
trending_markets: notification_destination_types[] // Email trending_markets: notification_destination_types[]
profit_loss_updates: notification_destination_types[] // Email profit_loss_updates: notification_destination_types[]
} }
export type notification_subscribe_types = 'all' | 'less' | 'none' export type notification_subscribe_types = 'all' | 'less' | 'none'

3
web/components/notification-settings.tsx
View File

@ -182,8 +182,6 @@ export function NotificationSettings() {
key, key,
]) ])
// for each entry in the exhaustive_notification_subscribe_types we'll want to load whether the user
// wants email, browser, both, or none
return ( return (
<Row className={clsx('my-1 gap-1 text-gray-300')}> <Row className={clsx('my-1 gap-1 text-gray-300')}>
<Col className="ml-3 gap-2 text-sm"> <Col className="ml-3 gap-2 text-sm">
@ -305,7 +303,6 @@ export function NotificationSettings() {
onClick={() => setShowWatchModal(true)} onClick={() => setShowWatchModal(true)}
/> />
</Row> </Row>
{/*// TODO: add none option to each section*/}
{Section( {Section(
<ChatIcon className={'h-6 w-6'} />, <ChatIcon className={'h-6 w-6'} />,
'New Comments', 'New Comments',