check if NaN when updating user balances

functions/src/create-answer.ts

@@ -122,6 +122,11 @@ export const createAnswer = functions.runWith({ minInstances: 1 }).https.onCall(
         totalBets: newTotalBets,
         answers: [...(contract.answers ?? []), answer],
       })
+
+      if (!isFinite(newBalance)) {
+        throw new Error('Invalid user balance for ' + user.username)
+      }
+
       transaction.update(userDoc, { balance: newBalance })
 
       return { status: 'success', answerId, betId: newBetDoc.id, answer }

functions/src/place-bet.ts

@@ -132,6 +132,10 @@ export const placeBet = functions.runWith({ minInstances: 1 }).https.onCall(
           })
         )
 
+        if (!isFinite(newBalance)) {
+          throw new Error('Invalid user balance for ' + user.username)
+        }
+
         transaction.update(userDoc, { balance: newBalance })
 
         return { status: 'success', betId: newBetDoc.id }

functions/src/redeem-shares.ts

@@ -78,6 +78,11 @@ export const redeemShares = async (userId: string, contractId: string) => {
     const user = userSnap.data() as User
 
     const newBalance = user.balance + netAmount
+
+    if (!isFinite(newBalance)) {
+      throw new Error('Invalid user balance for ' + user.username)
+    }
+
     transaction.update(userDoc, { balance: newBalance })
 
     transaction.create(yesDoc, yesBet)

functions/src/sell-bet.ts

@@ -67,6 +67,9 @@ export const sellBet = functions.runWith({ minInstances: 1 }).https.onCall(
               newBetDoc.id
             ) as any)
 
+      if (!isFinite(newBalance)) {
+        throw new Error('Invalid user balance for ' + user.username)
+      }
       transaction.update(userDoc, { balance: newBalance })
 
       transaction.update(betDoc, { isSold: true })