open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

check if NaN when updating user balances

Browse Source
This commit is contained in:
mantikoros 2022-03-15 22:05:08 -05:00
parent a150be88e2
commit 3f0002f9e8
4 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
functions/src/create-answer.ts
View File

@ -122,6 +122,11 @@ export const createAnswer = functions.runWith({ minInstances: 1 }).https.onCall(
totalBets: newTotalBets, totalBets: newTotalBets,
answers: [...(contract.answers ?? []), answer], answers: [...(contract.answers ?? []), answer],
}) })
if (!isFinite(newBalance)) {
throw new Error('Invalid user balance for ' + user.username)
}
transaction.update(userDoc, { balance: newBalance }) transaction.update(userDoc, { balance: newBalance })
return { status: 'success', answerId, betId: newBetDoc.id, answer } return { status: 'success', answerId, betId: newBetDoc.id, answer }

4
functions/src/place-bet.ts
View File

@ -132,6 +132,10 @@ export const placeBet = functions.runWith({ minInstances: 1 }).https.onCall(
}) })
) )
if (!isFinite(newBalance)) {
throw new Error('Invalid user balance for ' + user.username)
}
transaction.update(userDoc, { balance: newBalance }) transaction.update(userDoc, { balance: newBalance })
return { status: 'success', betId: newBetDoc.id } return { status: 'success', betId: newBetDoc.id }

5
functions/src/redeem-shares.ts
View File

@ -78,6 +78,11 @@ export const redeemShares = async (userId: string, contractId: string) => {
const user = userSnap.data() as User const user = userSnap.data() as User
const newBalance = user.balance + netAmount const newBalance = user.balance + netAmount
if (!isFinite(newBalance)) {
throw new Error('Invalid user balance for ' + user.username)
}
transaction.update(userDoc, { balance: newBalance }) transaction.update(userDoc, { balance: newBalance })
transaction.create(yesDoc, yesBet) transaction.create(yesDoc, yesBet)

3
functions/src/sell-bet.ts
View File

@ -67,6 +67,9 @@ export const sellBet = functions.runWith({ minInstances: 1 }).https.onCall(
newBetDoc.id newBetDoc.id
) as any) ) as any)
if (!isFinite(newBalance)) {
throw new Error('Invalid user balance for ' + user.username)
}
transaction.update(userDoc, { balance: newBalance }) transaction.update(userDoc, { balance: newBalance })
transaction.update(betDoc, { isSold: true }) transaction.update(betDoc, { isSold: true })