open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add some useEffect dependencies (#289)

Browse Source
This commit is contained in:
Marshall Polaris 2022-05-21 14:48:15 -07:00 committed by GitHub
parent cd602755be
commit 3db1de6b66
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/components/feed/feed-answer-comment-group.tsx
View File

@ -68,7 +68,7 @@ export function FeedAnswerCommentGroup(props: {
if (router.asPath.endsWith(`#${answerElementId}`)) { if (router.asPath.endsWith(`#${answerElementId}`)) {
setHighlighted(true) setHighlighted(true)
} }
}, [router.asPath]) }, [answerElementId, router.asPath])
return ( return (
<Col className={'flex-1 gap-2'}> <Col className={'flex-1 gap-2'}>

4
web/components/feed/feed-comments.tsx
View File

@ -132,7 +132,7 @@ export function FeedComment(props: {
if (router.asPath.endsWith(`#${comment.id}`)) { if (router.asPath.endsWith(`#${comment.id}`)) {
setHighlighted(true) setHighlighted(true)
} }
}, [router.asPath]) }, [comment.id, router.asPath])
// Only calculated if they don't have a matching bet // Only calculated if they don't have a matching bet
const { userPosition, outcome } = getBettorsLargestPositionBeforeTime( const { userPosition, outcome } = getBettorsLargestPositionBeforeTime(
@ -287,7 +287,7 @@ export function CommentInput(props: {
useEffect(() => { useEffect(() => {
if (!replyToUsername || !user || replyToUsername === user.username) return if (!replyToUsername || !user || replyToUsername === user.username) return
const replacement = `@${replyToUsername} ` const replacement = `@${replyToUsername} `
setComment(replacement + comment.replace(replacement, '')) setComment((comment) => replacement + comment.replace(replacement, ''))
}, [user, replyToUsername]) }, [user, replyToUsername])
async function submitComment(betId: string | undefined) { async function submitComment(betId: string | undefined) {