open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't push router

Browse Source
This commit is contained in:
James Grugett 2022-07-29 09:14:26 -07:00
parent 477fd70620
commit 37ad47db99
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
web/hooks/use-sort-and-query-params.tsx
View File

@ -86,8 +86,9 @@ export function useQueryAndSortParams(options?: {
} }
const setSort = (sort: Sort | undefined) => { const setSort = (sort: Sort | undefined) => {
router.query.s = sort router.replace({ query: { ...router.query, s: sort } }, undefined, {
router.push(router, undefined, { shallow: true }) shallow: true,
})
if (shouldLoadFromStorage) { if (shouldLoadFromStorage) {
localStorage.setItem(MARKETS_SORT, sort || '') localStorage.setItem(MARKETS_SORT, sort || '')
} }
@ -103,12 +104,9 @@ export function useQueryAndSortParams(options?: {
const pushQuery = useMemo( const pushQuery = useMemo(
() => () =>
debounce((query: string | undefined) => { debounce((query: string | undefined) => {
if (query) { router.replace({ query: { ...router.query, q: query } }, undefined, {
router.query.q = query shallow: true,
} else { })
delete router.query.q
}
router.replace(router, undefined, { shallow: true })
}, 100), }, 100),
[router] [router]
) )
@ -123,9 +121,12 @@ export function useQueryAndSortParams(options?: {
if (router.isReady && !sort && shouldLoadFromStorage) { if (router.isReady && !sort && shouldLoadFromStorage) {
const localSort = localStorage.getItem(MARKETS_SORT) as Sort const localSort = localStorage.getItem(MARKETS_SORT) as Sort
if (localSort) { if (localSort) {
router.query.s = localSort
// Use replace to not break navigating back. // Use replace to not break navigating back.
router.replace(router, undefined, { shallow: true }) router.replace(
{ query: { ...router.query, s: localSort } },
undefined,
{ shallow: true }
)
} }
} }
}) })