open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Eliminate needless state/effects to highlight comments

Browse Source
This commit is contained in:
Marshall Polaris 2022-09-21 14:08:56 -07:00
parent 7704de6904
commit 0228f26a6e
2 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
web/components/feed/feed-answer-comment-group.tsx
View File

@ -1,7 +1,7 @@
import { Answer } from 'common/answer'
import { FreeResponseContract } from 'common/contract'
import { ContractComment } from 'common/comment'
import React, { useEffect, useState } from 'react'
import React, { useState } from 'react'
import { Col } from 'web/components/layout/col'
import { Row } from 'web/components/layout/row'
import { Avatar } from 'web/components/avatar'
@ -27,15 +27,9 @@ export function FeedAnswerCommentGroup(props: {
const { username, avatarUrl, name, text } = answer
const [replyTo, setReplyTo] = useState<ReplyTo>()
const [highlighted, setHighlighted] = useState(false)
const router = useRouter()
const answerElementId = `answer-${answer.id}`
useEffect(() => {
if (router.asPath.endsWith(`#${answerElementId}`)) {
setHighlighted(true)
}
}, [answerElementId, router.asPath])
const highlighted = router.asPath.endsWith(`#${answerElementId}`)
return (
<Col className="relative flex-1 items-stretch gap-3">

9
web/components/feed/feed-comments.tsx
View File

@ -1,6 +1,6 @@
import { ContractComment } from 'common/comment'
import { Contract } from 'common/contract'
import React, { useEffect, useState } from 'react'
import React, { useState } from 'react'
import { useUser } from 'web/hooks/use-user'
import { formatMoney } from 'common/util/format'
import { useRouter } from 'next/router'
@ -94,13 +94,8 @@ export function FeedComment(props: {
money = formatMoney(Math.abs(comment.betAmount))
}
const [highlighted, setHighlighted] = useState(false)
const router = useRouter()
useEffect(() => {
if (router.asPath.endsWith(`#${comment.id}`)) {
setHighlighted(true)
}
}, [comment.id, router.asPath])
const highlighted = router.asPath.endsWith(`#${comment.id}`)
return (
<Row