open.source/manifold
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix free response answers with 0 bets disappearing (#427)

Browse Source 
Before this PR, free response answers and their associated comments disappeared when all shares in the answer were sold. If it's just an answer, this is a surprising UX but not that bad. But this can also disappear an entire comment thread with great discussion, as I noticed on one of my markets recently.

I suppose the downside is that these answers take up space and are more likely to be undesired - but I think answers with M$1 of bets are much more common anyway.
This commit is contained in:
Jack 2022-06-05 17:20:06 -07:00 committed by GitHub
parent a39b1e502c
commit 004dd7168e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/components/feed/activity-items.ts
View File

@ -200,9 +200,7 @@ function getAnswerGroups(
) { ) {
const { sortByProb, abbreviated, reversed } = options const { sortByProb, abbreviated, reversed } = options
let outcomes = uniq(bets.map((bet) => bet.outcome)).filter( let outcomes = uniq(bets.map((bet) => bet.outcome))
(outcome) => getOutcomeProbability(contract, outcome) > 0.0001
)
if (abbreviated) { if (abbreviated) {
const lastComment = last(comments) const lastComment = last(comments)
const lastCommentOutcome = bets.find( const lastCommentOutcome = bets.find(
@ -274,9 +272,7 @@ function getAnswerAndCommentInputGroups(
comments: Comment[], comments: Comment[],
user: User | undefined | null user: User | undefined | null
) { ) {
let outcomes = uniq(bets.map((bet) => bet.outcome)).filter( let outcomes = uniq(bets.map((bet) => bet.outcome))
(outcome) => getOutcomeProbability(contract, outcome) > 0.0001
)
outcomes = sortBy(outcomes, (outcome) => outcomes = sortBy(outcomes, (outcome) =>
getOutcomeProbability(contract, outcome) getOutcomeProbability(contract, outcome)
) )