open.source/magic-wormhole
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use TypeError for type errors, not UsageError

Browse Source
This commit is contained in:
Brian Warner 2015-10-06 20:52:47 -07:00
parent ce236ae70c
commit e77b39313a
4 changed files with 30 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/wormhole/blocking/transcribe.py
View File

@ -57,8 +57,8 @@ class Channel:
def send(self, phase, msg): def send(self, phase, msg):
# TODO: retry on failure, with exponential backoff. We're guarding # TODO: retry on failure, with exponential backoff. We're guarding
# against the rendezvous server being temporarily offline. # against the rendezvous server being temporarily offline.
if not isinstance(phase, type(u"")): raise UsageError(type(phase)) if not isinstance(phase, type(u"")): raise TypeError(type(phase))
if not isinstance(msg, type(b"")): raise UsageError(type(msg)) if not isinstance(msg, type(b"")): raise TypeError(type(msg))
self._sent_messages.add( (phase,msg) ) self._sent_messages.add( (phase,msg) )
payload = {"appid": self._appid, payload = {"appid": self._appid,
"channelid": self._channelid, "channelid": self._channelid,
@ -72,7 +72,7 @@ class Channel:
self._add_inbound_messages(resp["messages"]) self._add_inbound_messages(resp["messages"])
def get(self, phase): def get(self, phase):
if not isinstance(phase, type(u"")): raise UsageError(type(phase)) if not isinstance(phase, type(u"")): raise TypeError(type(phase))
# For now, server errors cause the client to fail. TODO: don't. This # For now, server errors cause the client to fail. TODO: don't. This
# will require changing the client to re-post messages when the # will require changing the client to re-post messages when the
# server comes back up. # server comes back up.
@ -146,8 +146,9 @@ class Wormhole:
version_warning_displayed = False version_warning_displayed = False
def __init__(self, appid, relay_url): def __init__(self, appid, relay_url):
if not isinstance(appid, type(u"")): raise UsageError if not isinstance(appid, type(u"")): raise TypeError(type(appid))
if not isinstance(relay_url, type(u"")): raise UsageError if not isinstance(relay_url, type(u"")):
raise TypeError(type(relay_url))
if not relay_url.endswith(u"/"): raise UsageError if not relay_url.endswith(u"/"): raise UsageError
self._appid = appid self._appid = appid
self._relay_url = relay_url self._relay_url = relay_url
@ -198,7 +199,7 @@ class Wormhole:
return code return code
def set_code(self, code): # used for human-made pre-generated codes def set_code(self, code): # used for human-made pre-generated codes
if not isinstance(code, type(u"")): raise UsageError if not isinstance(code, type(u"")): raise TypeError(type(code))
if self.code is not None: raise UsageError if self.code is not None: raise UsageError
self._set_code_and_channelid(code) self._set_code_and_channelid(code)
self._start() self._start()
@ -220,13 +221,13 @@ class Wormhole:
self.msg1 = self.sp.start() self.msg1 = self.sp.start()
def derive_key(self, purpose, length=SecretBox.KEY_SIZE): def derive_key(self, purpose, length=SecretBox.KEY_SIZE):
if not isinstance(purpose, type(u"")): raise UsageError if not isinstance(purpose, type(u"")): raise TypeError(type(purpose))
return HKDF(self.key, length, CTXinfo=to_bytes(purpose)) return HKDF(self.key, length, CTXinfo=to_bytes(purpose))
def _encrypt_data(self, key, data): def _encrypt_data(self, key, data):
assert isinstance(key, type(b"")), type(key) assert isinstance(key, type(b"")), type(key)
assert isinstance(data, type(b"")), type(data) assert isinstance(data, type(b"")), type(data)
if len(key) != SecretBox.KEY_SIZE: raise UsageError assert len(key) == SecretBox.KEY_SIZE, len(key)
box = SecretBox(key) box = SecretBox(key)
nonce = utils.random(SecretBox.NONCE_SIZE) nonce = utils.random(SecretBox.NONCE_SIZE)
return box.encrypt(data, nonce) return box.encrypt(data, nonce)
@ -234,7 +235,7 @@ class Wormhole:
def _decrypt_data(self, key, encrypted): def _decrypt_data(self, key, encrypted):
assert isinstance(key, type(b"")), type(key) assert isinstance(key, type(b"")), type(key)
assert isinstance(encrypted, type(b"")), type(encrypted) assert isinstance(encrypted, type(b"")), type(encrypted)
if len(key) != SecretBox.KEY_SIZE: raise UsageError assert len(key) == SecretBox.KEY_SIZE, len(key)
box = SecretBox(key) box = SecretBox(key)
data = box.decrypt(encrypted) data = box.decrypt(encrypted)
return data return data
@ -254,8 +255,9 @@ class Wormhole:
return self.verifier return self.verifier
def send_data(self, outbound_data, phase=u"data"): def send_data(self, outbound_data, phase=u"data"):
if not isinstance(outbound_data, type(b"")): raise UsageError if not isinstance(outbound_data, type(b"")):
if not isinstance(phase, type(u"")): raise UsageError raise TypeError(type(outbound_data))
if not isinstance(phase, type(u"")): raise TypeError(type(phase))
if phase in self._sent_data: raise UsageError # only call this once if phase in self._sent_data: raise UsageError # only call this once
if self.code is None: raise UsageError if self.code is None: raise UsageError
if self.channel is None: raise UsageError if self.channel is None: raise UsageError
@ -270,7 +272,7 @@ class Wormhole:
self.channel.send(phase, outbound_encrypted) self.channel.send(phase, outbound_encrypted)
def get_data(self, phase=u"data"): def get_data(self, phase=u"data"):
if not isinstance(phase, type(u"")): raise UsageError if not isinstance(phase, type(u"")): raise TypeError(type(phase))
if phase in self._got_data: raise UsageError # only call this once if phase in self._got_data: raise UsageError # only call this once
if self.code is None: raise UsageError if self.code is None: raise UsageError
if self.channel is None: raise UsageError if self.channel is None: raise UsageError

2
src/wormhole/test/test_blocking.py
View File

@ -229,7 +229,7 @@ class Blocking(ServerBase, unittest.TestCase):
self.assertRaises(UsageError, w1.get_data) self.assertRaises(UsageError, w1.get_data)
self.assertRaises(UsageError, w1.send_data, b"data") self.assertRaises(UsageError, w1.send_data, b"data")
w1.set_code(u"123-purple-elephant") w1.set_code(u"123-purple-elephant")
self.assertRaises(UsageError, w1.set_code, "123-nope") self.assertRaises(UsageError, w1.set_code, u"123-nope")
self.assertRaises(UsageError, w1.get_code) self.assertRaises(UsageError, w1.get_code)
w2 = Wormhole(APPID, self.relayurl) w2 = Wormhole(APPID, self.relayurl)
d = deferToThread(w2.get_code) d = deferToThread(w2.get_code)

2
src/wormhole/test/test_twisted.py
View File

@ -217,7 +217,7 @@ class Basic(ServerBase, unittest.TestCase):
self.assertRaises(UsageError, w1.send_data, b"data") self.assertRaises(UsageError, w1.send_data, b"data")
self.assertRaises(UsageError, w1.get_data) self.assertRaises(UsageError, w1.get_data)
w1.set_code(u"123-purple-elephant") w1.set_code(u"123-purple-elephant")
self.assertRaises(UsageError, w1.set_code, "123-nope") self.assertRaises(UsageError, w1.set_code, u"123-nope")
self.assertRaises(UsageError, w1.get_code) self.assertRaises(UsageError, w1.get_code)
w2 = Wormhole(APPID, self.relayurl) w2 = Wormhole(APPID, self.relayurl)
d = w2.get_code() d = w2.get_code()

25
src/wormhole/twisted/transcribe.py
View File

@ -90,8 +90,8 @@ class Channel:
def send(self, phase, msg): def send(self, phase, msg):
# TODO: retry on failure, with exponential backoff. We're guarding # TODO: retry on failure, with exponential backoff. We're guarding
# against the rendezvous server being temporarily offline. # against the rendezvous server being temporarily offline.
if not isinstance(phase, type(u"")): raise UsageError(type(phase)) if not isinstance(phase, type(u"")): raise TypeError(type(phase))
if not isinstance(msg, type(b"")): raise UsageError(type(msg)) if not isinstance(msg, type(b"")): raise TypeError(type(msg))
self._sent_messages.add( (phase,msg) ) self._sent_messages.add( (phase,msg) )
payload = {"appid": self._appid, payload = {"appid": self._appid,
"channelid": self._channelid, "channelid": self._channelid,
@ -103,6 +103,7 @@ class Channel:
return d return d
def get(self, phase): def get(self, phase):
if not isinstance(phase, type(u"")): raise TypeError(type(phase))
# fire with a bytestring of the first message for 'phase' that wasn't # fire with a bytestring of the first message for 'phase' that wasn't
# one of ours. It will either come from previously-received messages, # one of ours. It will either come from previously-received messages,
# or from an EventSource that we attach to the corresponding URL # or from an EventSource that we attach to the corresponding URL
@ -177,8 +178,9 @@ class Wormhole:
version_warning_displayed = False version_warning_displayed = False
def __init__(self, appid, relay_url): def __init__(self, appid, relay_url):
if not isinstance(appid, type(u"")): raise UsageError if not isinstance(appid, type(u"")): raise TypeError(type(appid))
if not isinstance(relay_url, type(u"")): raise UsageError if not isinstance(relay_url, type(u"")):
raise TypeError(type(relay_url))
if not relay_url.endswith(u"/"): raise UsageError if not relay_url.endswith(u"/"): raise UsageError
self._appid = appid self._appid = appid
self._relay_url = relay_url self._relay_url = relay_url
@ -231,7 +233,7 @@ class Wormhole:
return d return d
def set_code(self, code): def set_code(self, code):
if not isinstance(code, type(u"")): raise UsageError if not isinstance(code, type(u"")): raise TypeError(type(code))
if self.code is not None: raise UsageError if self.code is not None: raise UsageError
self._set_code_and_channelid(code) self._set_code_and_channelid(code)
self._start() self._start()
@ -280,7 +282,7 @@ class Wormhole:
return self return self
def derive_key(self, purpose, length=SecretBox.KEY_SIZE): def derive_key(self, purpose, length=SecretBox.KEY_SIZE):
if not isinstance(purpose, type(u"")): raise UsageError if not isinstance(purpose, type(u"")): raise TypeError(type(purpose))
if self.key is None: if self.key is None:
# call after get_verifier() or get_data() # call after get_verifier() or get_data()
raise UsageError raise UsageError
@ -289,7 +291,7 @@ class Wormhole:
def _encrypt_data(self, key, data): def _encrypt_data(self, key, data):
assert isinstance(key, type(b"")), type(key) assert isinstance(key, type(b"")), type(key)
assert isinstance(data, type(b"")), type(data) assert isinstance(data, type(b"")), type(data)
if len(key) != SecretBox.KEY_SIZE: raise UsageError assert len(key) == SecretBox.KEY_SIZE, len(key)
box = SecretBox(key) box = SecretBox(key)
nonce = utils.random(SecretBox.NONCE_SIZE) nonce = utils.random(SecretBox.NONCE_SIZE)
return box.encrypt(data, nonce) return box.encrypt(data, nonce)
@ -297,7 +299,7 @@ class Wormhole:
def _decrypt_data(self, key, encrypted): def _decrypt_data(self, key, encrypted):
assert isinstance(key, type(b"")), type(key) assert isinstance(key, type(b"")), type(key)
assert isinstance(encrypted, type(b"")), type(encrypted) assert isinstance(encrypted, type(b"")), type(encrypted)
if len(key) != SecretBox.KEY_SIZE: raise UsageError assert len(key) == SecretBox.KEY_SIZE, len(key)
box = SecretBox(key) box = SecretBox(key)
data = box.decrypt(encrypted) data = box.decrypt(encrypted)
return data return data
@ -324,8 +326,9 @@ class Wormhole:
return d return d
def send_data(self, outbound_data, phase=u"data"): def send_data(self, outbound_data, phase=u"data"):
if not isinstance(outbound_data, type(b"")): raise UsageError if not isinstance(outbound_data, type(b"")):
if not isinstance(phase, type(u"")): raise UsageError raise TypeError(type(outbound_data))
if not isinstance(phase, type(u"")): raise TypeError(type(phase))
if phase in self._sent_data: raise UsageError # only call this once if phase in self._sent_data: raise UsageError # only call this once
if self.code is None: raise UsageError if self.code is None: raise UsageError
if self.channel is None: raise UsageError if self.channel is None: raise UsageError
@ -343,7 +346,7 @@ class Wormhole:
return d return d
def get_data(self, phase=u"data"): def get_data(self, phase=u"data"):
if not isinstance(phase, type(u"")): raise UsageError if not isinstance(phase, type(u"")): raise TypeError(type(phase))
if phase in self._got_data: raise UsageError # only call this once if phase in self._got_data: raise UsageError # only call this once
if self.code is None: raise UsageError if self.code is None: raise UsageError
if self.channel is None: raise UsageError if self.channel is None: raise UsageError