open.source/magic-wormhole
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

don't log HTTP requests when blur-usage is on

Browse Source
This commit is contained in:
Brian Warner 2015-12-04 17:35:56 -08:00
parent 1ab66d2fd0
commit 9ed39be346
3 changed files with 46 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/wormhole/servers/relay_server.py
View File

@ -63,10 +63,11 @@ class EventsProtocol:
# all JSON responses include a "welcome:{..}" key
class RelayResource(resource.Resource):
def __init__(self, relay, welcome):
def __init__(self, relay, welcome, log_requests):
resource.Resource.__init__(self)
self._relay = relay
self._welcome = welcome
self._log_requests = log_requests
class ChannelLister(RelayResource):
def render_GET(self, request):
@ -93,6 +94,7 @@ class Allocator(RelayResource):
app = self._relay.get_app(appid)
channelid = app.find_available_channelid()
app.allocate_channel(channelid, side)
if self._log_requests:
log.msg("allocated #%d, now have %d DB channels" %
(channelid, len(app.get_allocated())))
request.setHeader(b"content-type", b"application/json; charset=utf-8")
@ -207,11 +209,13 @@ class Deallocator(RelayResource):
class Channel:
def __init__(self, app, db, welcome, blur_usage, appid, channelid):
def __init__(self, app, db, welcome, blur_usage, log_requests,
appid, channelid):
self._app = app
self._db = db
self._welcome = welcome
self._blur_usage = blur_usage
self._log_requests = log_requests
self._appid = appid
self._channelid = channelid
self._listeners = set() # callbacks that take JSONable object
@ -385,10 +389,11 @@ class Channel:
class AppNamespace:
def __init__(self, db, welcome, blur_usage, appid):
def __init__(self, db, welcome, blur_usage, log_requests, appid):
self._db = db
self._welcome = welcome
self._blur_usage = blur_usage
self._log_requests = log_requests
self._appid = appid
self._channels = {}
@ -422,9 +427,11 @@ class AppNamespace:
def get_channel(self, channelid):
assert isinstance(channelid, int)
if not channelid in self._channels:
if self._log_requests:
log.msg("spawning #%d for appid %s" % (channelid, self._appid))
self._channels[channelid] = Channel(self, self._db, self._welcome,
self._blur_usage,
self._log_requests,
self._appid, channelid)
return self._channels[channelid]
@ -434,10 +441,16 @@ class AppNamespace:
if channelid in self._channels:
self._channels.pop(channelid)
if self._log_requests:
log.msg("freed+killed #%d, now have %d DB channels, %d live" %
(channelid, len(self.get_allocated()), len(self._channels)))
def prune_old_channels(self):
# For now, pruning is logged even if log_requests is False, to debug
# the pruning process, and since pruning is triggered by a timer
# instead of by user action. It does reveal which channels were
# present when the pruning process began, though, so in the log run
# it should do less logging.
log.msg(" channel prune begins")
# a channel is deleted when there are no listeners and there have
# been no messages added in CHANNEL_EXPIRATION_TIME seconds
@ -459,15 +472,17 @@ class Relay(resource.Resource, service.MultiService):
self._db = db
self._welcome = welcome
self._blur_usage = blur_usage
log_requests = blur_usage is None
self._log_requests = log_requests
self._apps = {}
t = internet.TimerService(EXPIRATION_CHECK_PERIOD, self.prune)
t.setServiceParent(self)
self.putChild(b"list", ChannelLister(self, welcome))
self.putChild(b"allocate", Allocator(self, welcome))
self.putChild(b"add", Adder(self, welcome))
self.putChild(b"get", GetterOrWatcher(self, welcome))
self.putChild(b"watch", Watcher(self, welcome))
self.putChild(b"deallocate", Deallocator(self, welcome))
self.putChild(b"list", ChannelLister(self, welcome, log_requests))
self.putChild(b"allocate", Allocator(self, welcome, log_requests))
self.putChild(b"add", Adder(self, welcome, log_requests))
self.putChild(b"get", GetterOrWatcher(self, welcome, log_requests))
self.putChild(b"watch", Watcher(self, welcome, log_requests))
self.putChild(b"deallocate", Deallocator(self, welcome, log_requests))
def getChild(self, path, req):
# 0.4.0 used "POST /CID/SIDE/post/MSGNUM"
@ -481,12 +496,15 @@ class Relay(resource.Resource, service.MultiService):
def get_app(self, appid):
assert isinstance(appid, type(u""))
if not appid in self._apps:
if self._log_requests:
log.msg("spawning appid %s" % (appid,))
self._apps[appid] = AppNamespace(self._db, self._welcome,
self._blur_usage, appid)
self._blur_usage,
self._log_requests, appid)
return self._apps[appid]
def prune(self):
# As with AppNamespace.prune_old_channels, we log for now.
log.msg("beginning app prune")
c = self._db.execute("SELECT DISTINCT `appid` FROM `messages`")
apps = set([row["appid"] for row in c.fetchall()]) # these have messages

12
src/wormhole/servers/server.py
View File

@ -15,6 +15,12 @@ class Root(resource.Resource):
resource.Resource.__init__(self)
self.putChild(b"", static.Data(b"Wormhole Relay\n", "text/plain"))
class PrivacyEnhancedSite(server.Site):
logRequests = True
def log(self, request):
if self.logRequests:
return server.Site.log(self, request)
class RelayServer(service.MultiService):
def __init__(self, relayport, transitport, advertise_version,
db_url=":memory:", blur_usage=None):
@ -33,7 +39,9 @@ class RelayServer(service.MultiService):
if advertise_version:
welcome["current_version"] = advertise_version
self.root = Root()
site = server.Site(self.root)
site = PrivacyEnhancedSite(self.root)
if blur_usage:
site.logRequests = False
r = endpoints.serverFromString(reactor, relayport)
self.relayport_service = ServerEndpointService(r, site)
self.relayport_service.setServiceParent(self)
@ -45,10 +53,12 @@ class RelayServer(service.MultiService):
t = endpoints.serverFromString(reactor, transitport)
self.transport_service = ServerEndpointService(t, self.transit)
self.transport_service.setServiceParent(self)
def startService(self):
service.MultiService.startService(self)
log.msg("Wormhole relay server (Rendezvous and Transit) running")
if self._blur_usage:
log.msg("blurring access times to %d seconds" % self._blur_usage)
log.msg("not logging HTTP requests")
else:
log.msg("not blurring access times")

2
src/wormhole/test/test_server.py
View File

@ -363,7 +363,7 @@ class OneEventAtATime:
class Summary(unittest.TestCase):
def test_summarize(self):
c = relay_server.Channel(None, None, None, None, None, None)
c = relay_server.Channel(None, None, None, None, False, None, None)
A = relay_server.ALLOCATE
D = relay_server.DEALLOCATE