open.source/magic-wormhole
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

minor TODO comments

Browse Source
This commit is contained in:
Brian Warner 2017-04-06 19:44:27 -07:00
parent 6aa7fe7c82
commit 992db1846c
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/wormhole/test/test_wormhole.py
View File

@ -127,7 +127,8 @@ class Wormholes(ServerBase, unittest.TestCase):
version1 = yield w1.when_version() version1 = yield w1.when_version()
version2 = yield w2.when_version() version2 = yield w2.when_version()
# TODO: add the ability to set app-versions # app-versions are exercised properly in test_versions, this just
# tests the defaults
self.assertEqual(version1, {}) self.assertEqual(version1, {})
self.assertEqual(version2, {}) self.assertEqual(version2, {})

5
src/wormhole/wormhole.py
View File

@ -131,7 +131,10 @@ class _DeferredWormhole(object):
# from above # from above
def when_code(self): def when_code(self):
# TODO: consider throwing error unless one of allocate/set/input_code # TODO: consider throwing error unless one of allocate/set/input_code
# was called first # was called first. It's legit to grab the Deferred before triggering
# the process that will cause it to fire, but forbidding that
# ordering would make it easier to cause programming errors that
# forget to trigger it entirely.
if self._observer_result is not None: if self._observer_result is not None:
return defer.fail(self._observer_result) return defer.fail(self._observer_result)
if self._code is not None: if self._code is not None: