open.source/magic-wormhole
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

logic bug: M.S4B.close() must not re-send RELEASE

Browse Source
This commit is contained in:
Brian Warner 2017-02-25 13:12:56 -08:00
parent 41b7bcfed5
commit 97d1ff859b
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
docs/mailbox_close.dot
View File

@ -27,6 +27,8 @@ digraph {
SrcA -> Prc [label="connected"]
Prc [shape="box" label="C.tx_release\nC.tx_close" color="orange"]
Prc -> SrcB [color="orange"]
Prc2 [shape="box" label="C.tx_close" color="orange"]
Prc2 -> SrcB [color="orange"]
SrcB [label="SrcB:\nwaiting for:\nrelease\nclosed" color="orange"]
SrcB -> SrcA [label="lost"]
SrcB -> ScB [label="rx_released" color="orange" fontcolor="orange"]
@ -65,7 +67,7 @@ digraph {
S4A [label="S4A" style="dashed"]
S4B [label="S4B" color="orange" style="dashed"]
S4A -> SrcA [style="dashed"]
S4B -> Prc [color="orange" style="dashed"]
S4B -> Prc2 [color="orange" style="dashed"]
S5A [label="S5A" style="dashed"]
S5B [label="S5B" color="green" style="dashed"]

3
src/wormhole/_mailbox.py
View File

@ -263,8 +263,7 @@ class Mailbox(object):
S3B.upon(close, enter=SrcB,
outputs=[record_mood_and_RC_tx_release_and_RC_tx_close])
S4A.upon(close, enter=SrcA, outputs=[record_mood])
S4B.upon(close, enter=SrcB,
outputs=[record_mood_and_RC_tx_release_and_RC_tx_close])
S4B.upon(close, enter=SrcB, outputs=[record_mood_and_RC_tx_close])
S5A.upon(close, enter=ScA, outputs=[record_mood])
S5B.upon(close, enter=ScB, outputs=[record_mood_and_RC_tx_close])